Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pin (with KBS) handler when registration #110

Open
EcoloSweet opened this issue Aug 30, 2021 · 1 comment
Open

Add pin (with KBS) handler when registration #110

EcoloSweet opened this issue Aug 30, 2021 · 1 comment

Comments

@EcoloSweet
Copy link

When an account is already pin protected, it is currently impossible register and to unlock it.

I don't really understand what is the use of KBS and I'm not sure we have the tools needed to provide it. But now, it seems to be the only registration lock pin accepted (the old pin method isn't accepted by signal servers).

This is how signal-cli did it in their java implementation :

AsamK/signal-cli@425626e

Is there an easy way to add this in one of the libsignal-service-rs crates ?

@rubdos
Copy link
Member

rubdos commented Aug 30, 2021

Is there an easy way to add this in one of the libsignal-service-rs crates ?

Depends on how much of the crypto already resides in libsignal-client, which is literally nothing, at first grep.

I'm afraid the KBS is quite some engineering work, for which I personally don't have a lot of time. I'll be glad to help you in the progress by reviewing code, however. I've been in contact with some people at Signal, and they are interested in moving cryptographic primitives into libsignal-client, whenever there's a clear win for them. I do suggest however to first experiment against our crates, and then start the discussion of which code we can move.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants