-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for matrix-inverted-already attribute in GatingML #131
Comments
Thanks for the feedback. I must have missed this option in the specification. I'll take a look at adding support for this. Any chance you can provide an example GatingML document that uses this? -Scott |
On-hold until I have an example GatingML file using |
I'm not sure if my request is useful anymore. I guess I'd suggest closing as "won't fix" until a more compelling use case comes up |
I'm definitely open to supporting it, just need an example of a valid example Diva XML file using the |
I'm a bit late to the party, but:
Matrix inversions are basically exact up to a negligible numerical error, you'll lose nothing of relevance by inverting your spillover matrix a couple of times. |
Is your feature request related to a problem? Please describe.
FlowKit does not appear to use the matrix-inverted-already flag in GatingML
Describe the solution you'd like
It would be nice if FlowKit could use an already inverted matrix. For example, the DIVA vendor specific XML files already include a compensation matrix, but it appears to be already inverted. I'd like to use their matrix as-is without going thru a matrix inversion to avoid adding more noise.
Describe alternatives you've considered
I can invert the matrix found in DIVA vendor specific files and not use the matrix-inverted-already flag when generating GatingML files to use with FlowKit
Additional context
The text was updated successfully, but these errors were encountered: