Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

Threads remains white #89

Open
yousefcodes opened this issue Mar 27, 2019 · 15 comments
Open

Threads remains white #89

yousefcodes opened this issue Mar 27, 2019 · 15 comments

Comments

@yousefcodes
Copy link

The "All Threads" view remains white.

@abstractamcr
Copy link

abstractamcr commented Mar 31, 2019

Just gave it all a whirl and the message body where the conversation happens is still white on version 3.3.8. Everything else turned black as it should have. I also pulled down the latest CSS local and tried that but got some results.

@devbyray
Copy link

devbyray commented Apr 3, 2019

For me the same!

@mmiraldi
Copy link

mmiraldi commented Apr 3, 2019

@abstractamcr and @raymonschouwenaar try using the css from my fork. You can use the following url while we wait for the changes (#90 ) to be merged.
https://mmiraldi.github.io/slack-black-theme/custom.css
After the merge, I plan to rebase my fork on @Nockiro 's because that seems to be the most comprehensive and well maintained relative to Slack version changes:
https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css

@derkling
Copy link

derkling commented Apr 3, 2019

Works for me... the "All Threads" is now black. But there is an issue with the left menu.
I get the "All Threads" which falls behind the "Jump to" search box... as you can hopefully see from this small screenshot: https://pasteboard.co/I8rSBEu.png

@mmiraldi
Copy link

mmiraldi commented Apr 3, 2019

@derkling that issue exists in the head of branch:master and is not addressed by #90 ... I purposefully constrained the scope of that pull request to maximize the probability of a quick merge to fix op's issue. The "Jump to" overlap (among other issues) is fixed in the second css of my above comment. Unfortunately pull request #60 has been waiting since 2018-07-21 and that fork has diverged more since then (credit to @Nockiro for keeping up with Slack developments).

@Snowflake6
Copy link

@abstractamcr and @raymonschouwenaar try using the css from my fork. You can use the following url while we wait for the changes (#90 ) to be merged.
https://mmiraldi.github.io/slack-black-theme/custom.css

Forgive a silly question, but Where does this go? Do I copy the content into the two files as per the normal instructions? Or does custom.css just go in that folder?

@bwright2810
Copy link

bwright2810 commented Apr 9, 2019

@Snowflake6 it goes in the below part of the Javascript you add to the bottom of the files:
// Fetch our CSS in parallel ahead of time
const cssPath = 'https://cdn.rawgit.com/widget-/slack-black-theme/master/custom.css';

@Snowflake6
Copy link

Snowflake6 commented Apr 9, 2019

@Snowflake6 it goes in the below part of the Javascript you add to the bottom of the files:
// Fetch our CSS in parallel ahead of time
const cssPath = 'https://cdn.rawgit.com/widget-/slack-black-theme/master/custom.css';

Doh! Of course. [edit] Yep, that's fixed it. Had to re-start Slack to get everything to re-load properly, but now i've got dark backgrounds in both main window and in the reply threads. And as a bonus, the input field for posting and replying now has better contrast so I can see what i'm typing... Thanks!

@alikrc
Copy link

alikrc commented Apr 12, 2019

For your security don't use the link directly it may create xss. Copy paste that css. Btw is it completely working on https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css ?

@SympaticoIV
Copy link

SympaticoIV commented Apr 14, 2019

For your security don't use the link directly it may create xss. Copy paste that css. Btw is it completely working on https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css ?

Worked perfectly for me! Thank goodness, my eyes are saved. Thank you!

@ATLTrailBlazer
Copy link

ATLTrailBlazer commented May 1, 2019

I signed up just to say thanks! My eyes thank you. Had this same problem and switching to the new CSS link worked!

@ghost
Copy link

ghost commented Jun 4, 2019

New CSS link works just fine ;) Thanks !

@webbydevvy
Copy link

This worked for me, css wise, FINALLY no more white background! However, I am now getting this weird button overlay in the top left, which feels a bit janky. I can't seem to get rid of the "jump to" quick search. Anyone else?

Screenshot 2019-06-21 at 10 32 50

@eduardoRubioG
Copy link

For those that might still be unsure of how to resolve this issue:

Open your Slack application package contents and go into:

Contents/Resources/app.asar.unpacked/src/static/ssb-interop.js

Then, go to the line that declares the cssPath variable and change it from:

const cssPath = 'https://cdn.rawgit.com/widget-/slack-black-theme/master/custom.css';

to:

const cssPath = 'https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css';

Restart the app and it should be looking better!

@willpetty
Copy link

const cssPath = 'https://raw.githubusercontent.com/Nockiro/slack-black-theme/master/custom.css';
^ worked best for me. The Previous css replacement in the comments above worked, but not on the text in a "Thread" ( in this case, standup_alice bot)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests