Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still some bugs while using multiple decline reasons #120

Open
enterprisey opened this issue Jan 9, 2021 · 2 comments
Open

Still some bugs while using multiple decline reasons #120

enterprisey opened this issue Jan 9, 2021 · 2 comments
Labels
C-bug Category: bug

Comments

@enterprisey
Copy link
Contributor

The code implementing multiple decline reasons needs to be looked over again, because I think there are still more bugs. I'm sure there are bug reports somewhere on WT:WPAFC.

@enterprisey enterprisey mentioned this issue Jan 9, 2021
9 tasks
@primefac
Copy link

primefac commented Jan 9, 2021

The main issue is when reason2 contains a value that would normally have a secondary input (such as the language, merge target, or URL) that secondary input is not automatically included and needs to be added manually.

I'm likely misremembering, but I actually think that is the issue.

@enterprisey enterprisey added the C-bug Category: bug label Jan 16, 2021
@enterprisey
Copy link
Contributor Author

That's certainly part of it, if not all of it. From the report at https://en.wikipedia.org/w/index.php?diff=958290240, the generated template was:

{{AFC submission|d|v|Spanish|u=Gianluigi Feliu|ns=118|decliner=Robert McClenon|declinets=20200522233914|reason2=lang|ts=20200522225318}}

"Spanish" should've gone to details2, not details (aka anonymous parameter 3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug
Projects
None yet
Development

No branches or pull requests

2 participants