Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-admins cannot close XFDs with more than 50 pages #60

Open
2 tasks
NovemLinguae opened this issue Jun 2, 2024 · 2 comments · May be fixed by #87
Open
2 tasks

non-admins cannot close XFDs with more than 50 pages #60

NovemLinguae opened this issue Jun 2, 2024 · 2 comments · May be fixed by #87
Labels
frequently-requested

Comments

@NovemLinguae
Copy link
Member

NovemLinguae commented Jun 2, 2024 •
edited
Loading

Reported by Qwerfjkl at https://en.wikipedia.org/wiki/Wikipedia_talk:XFDcloser#Most_urgent_bugs

Probably hitting the API limit for non-admins. Need to put the API query in a loop, or use the API's continue feature, or something.

Acceptance criteria

  • non-admin can close a CFD with 51 categories
  • non-admin can close an MFD with 51 pages
@Qwerfjkl
Copy link

Qwerfjkl commented Jun 2, 2024 •
edited
Loading

I suspect it's from

xfdcloser/xfdcloser-src/Controllers/DiscussionViewController.js

Lines 29 to 44 in df2d5b6

fetchInfoFromApi() {
const pagesExistencesPromise = API.get({
action: "query",
format: "json",
formatversion: 2,
titles: this.model.pagesNames,
prop: "info",
inprop: "talkid"
}).then(response => response.query.pages.forEach(page => {
const pageTitle = mw.Title.newFromText(page.title);
const talkpageTitle = pageTitle.getTalkPage();
mw.Title.exist.set(pageTitle.getPrefixedDb(), !page.missing);
if ( talkpageTitle ) {
mw.Title.exist.set(talkpageTitle.getPrefixedDb(), !!page.talkid);
}
}));

though it might be better to handle this in api.js.

@93Pd9s8Jt 93Pd9s8Jt mentioned this issue Jun 25, 2024
Closed
@Qwerfjkl Qwerfjkl linked a pull request Jun 25, 2024 that will close this issue
Open
@NovemLinguae
Copy link
Member Author

Reported again today by Alalch E. at https://en.wikipedia.org/wiki/Wikipedia_talk:XFDcloser#Toomanyvalues

Affects this MFD that has 63 pages: https://en.wikipedia.org/wiki/Wikipedia:Miscellany_for_deletion/User:HeyDuggeeOfficial2024/sandbox/The_Olden_Days

The API error message is "Toomanyvalues"

@NovemLinguae NovemLinguae changed the title non-admins cannot close CFDs with more than 50 categories non-admins cannot close XFDs with more than 50 pages Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frequently-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add chunking for API requests Qwerfjkl/xfdcloser
Add chunking for API requests
2 participants
@NovemLinguae @Qwerfjkl