You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The issue is that the hooks instance addresses are derived solely from the contract nonce, so if there are reorgs on sidechains and multiple people had deployed in the same time period, the instance addresses could be swapped if the transactions are reordered. Low impact but worth addressing.
Solution: Use Create2 to deploy hooks instances, with salt derived from sender address and a partial salt provided by the caller (same as market salt derivation).
The text was updated successfully, but these errors were encountered:
Finding: Hook deployment is vulnerable to reorg situations
The issue is that the hooks instance addresses are derived solely from the contract nonce, so if there are reorgs on sidechains and multiple people had deployed in the same time period, the instance addresses could be swapped if the transactions are reordered. Low impact but worth addressing.
Solution: Use Create2 to deploy hooks instances, with salt derived from sender address and a partial salt provided by the caller (same as market salt derivation).
The text was updated successfully, but these errors were encountered: