Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C4 Finding] Fixed term markets do not update the end time on closure #46

Closed
d1ll0n opened this issue Oct 9, 2024 · 1 comment
Closed

Comments

@d1ll0n
Copy link
Contributor

d1ll0n commented Oct 9, 2024

Finding: No lender is able to exit even after the market is closed

When a fixed term market closes, the end timestamp is not updated, leading to lenders being forced to wait for withdrawal on an inactive market while not being paid interest.

Solution: Force useOnCloseMarket to be enabled, and in onCloseMarket set the end time to the block timestamp of the closure.

@laurenceday
Copy link
Contributor

Fixed by 05958e3

Dillon adding another commit with a missing event, but core functionality of fix in the above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants