You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Migrate the label geoms off ggfittext's private grob internals onto its publicfit_text_grob() constructor (exported in ggfittext 0.11.0 — wilkox/ggfittext#70).
Why this is a gate, not just cleanup
gggenes currently hand-rolls ggfittext's private grob. In R/compose_grob.R
the text branch constructs the ggfittext gTree directly:
This reaches into exactly the private contract that ggfittext 0.12.0 will
change (0.12.0 carries the coord_radial() polar-label fix and, per its
milestone, "changes the (private) linear gTree contract, so lands after the
downstream-migration gate"). ggfittext 0.11.0 exists specifically as that gate:
downstream packages migrate onto fit_text_grob()before the internals move.
Consequently gggenes must migrate to fit_text_grob()before it can adopt
ggfittext 0.12.0 — i.e. before coord_radial() (#96) can be finalised.
Skipping this would mean the ggfittext bump that unblocks coord_radial
simultaneously breaks existing label rendering.
Scope
Replace both hand-rolled gTree constructions in R/compose_grob.R (the fittexttree and fittexttreepolar cases) with ggfittext::fit_text_grob().
Goal
Migrate the label geoms off ggfittext's private grob internals onto its
public
fit_text_grob()constructor (exported in ggfittext 0.11.0 —wilkox/ggfittext#70).
Why this is a gate, not just cleanup
gggenes currently hand-rolls ggfittext's private grob. In
R/compose_grob.Rthe text branch constructs the ggfittext gTree directly:
This reaches into exactly the private contract that ggfittext 0.12.0 will
change (0.12.0 carries the
coord_radial()polar-label fix and, per itsmilestone, "changes the (private) linear gTree contract, so lands after the
downstream-migration gate"). ggfittext 0.11.0 exists specifically as that gate:
downstream packages migrate onto
fit_text_grob()before the internals move.Consequently gggenes must migrate to
fit_text_grob()before it can adoptggfittext 0.12.0 — i.e. before
coord_radial()(#96) can be finalised.Skipping this would mean the ggfittext bump that unblocks coord_radial
simultaneously breaks existing label rendering.
Scope
R/compose_grob.R(thefittexttreeandfittexttreepolarcases) withggfittext::fit_text_grob().DESCRIPTIONtoImports: ggfittext (>= 0.11.0)(coordinate with theggplot2 floor review, Review and rationalise the declared ggplot2 version floor (DESCRIPTION says >= 2.2.1) #107).
for every
*_labelgeom across all coordinate systems).Dependencies
fit_text_grob()) landing on CRAN.coord_radial(), which requires ggfittext ≥ 0.12.0 and hencethis migration first.