Skip to content

Add cache tags #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add cache tags #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
910c349
Update NotificationType.php
TheNewSound Feb 25, 2023
bfd6c28
Update Schedulable.php
TheNewSound Feb 25, 2023
8d6598f
Update src/NotificationType.php
TheNewSound Mar 4, 2023
5b57a19
Update composer.json for Laravel 10 and 11
TheNewSound Dec 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"minimum-stability": "dev",
"require": {
"php": "^8.0",
"illuminate/notifications": "~5.6 || ~6.0 || ~7.0 || ~8.0 || ~9.0"
"illuminate/notifications": ">=5.6 <11.0 || ^11.0"
},
"config": {
"sort-packages": true
Expand Down
4 changes: 2 additions & 2 deletions src/NotificationType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public static function boot() {
parent::boot();

$callback = function ($notificationType) {
cache()->forget("notifications:$notificationType->name");
cache()->tags('notification_settings')->forget("notifications:$notificationType->name");
};

static::saved($callback);
Expand All @@ -77,7 +77,7 @@ public function notifications()
*/
public static function isEnabled($notificationType)
{
$settings = cache()->rememberForever("notifications:$notificationType", function () use ($notificationType) {
$settings = cache()->tags('notification_settings')->rememberForever("notifications:$notificationType", function () use ($notificationType) {
return NotificationType::whereName($notificationType)->first();
});

Expand Down
2 changes: 1 addition & 1 deletion src/Schedulable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public function viaQueues()
}

$notificationType = get_class($this);
$settings = cache()->rememberForever("notifications:$notificationType", function () use ($notificationType) {
$settings = cache()->tags('notification_settings')->rememberForever("notifications:$notificationType", function () use ($notificationType) {
return NotificationType::whereName($notificationType)->first();
});

Expand Down