Nachrichten: ein Feld, das Mitglieder und andere Netzwerke zugleich findet (#2254)

Die Nachrichtenliste nahm bisher nur eine Fediverse-Adresse entgegen, und
Mitglieder erreichte man ausschließlich über deren Profil. Das sind zwei Wege
für dieselbe Frage. Über der Liste steht jetzt ein Feld, das beide Welten
durchsucht: Mitglieder nach Vorname, Nachname, beidem oder Handle, dazu die
Konten anderer Netzwerke, die diese Installation ohnehin schon hält. Beides
kostet nichts nach draußen. Eine Adresse, die hier niemand kennt, bekommt eine
eigene Zeile "Diese Adresse nachschlagen" — das ist der einzige Teil, der das
Haus verlässt, und deshalb ein Druck und nichts, was beim Tippen passiert.

Die Namenssuche zieht in `Accounts.search_people/3`, wo sie hingehört; der
Composer hatte seine eigene unter `Posts.search_users/3`, weil er sie zuerst
brauchte. Neu ist dabei die umgekehrte Reihenfolge: "Petersen Jan" findet Jan
Petersen, weil im deutschen Büro beide Reihenfolgen selbstverständlich sind.
`Fediverse.search_accounts/2` ist die Typeahead-Hälfte neben der exakten
Adresssuche.

Was das Feld kann, steht als Satz darunter, nicht im Platzhalter: die zweite
Hälfte ist nicht erratbar, und ohne Fediverse-Teilnahme gibt es sie nicht —
dann sucht das Feld nur auf vutuv und sagt, wo der Schalter sitzt. Das
`change`-Attribut am geteilten Adressformular ist wieder weg, es hatte mit
diesem Umbau keinen Aufrufer mehr.

Diesen Text hat ein KI-Agent in meinem Namen geschrieben. Ich weiß, dass das
problematisch ist.

Author: wintermeyer

docs/architecture/messages.md

@@ -212,16 +212,29 @@ the hourly outbound budget with public replies.
 
 ### Starting one, and finding the way back
 
-Every other conversation here starts from somebody's page. An account nobody
-on this installation has ever heard of has no page, so `/messages` carries a
-**New message to another network** box: an address in, that account's
-conversation out. Resolving costs an outbound request and a slot of the
-member's hourly budget, so it is a submit they make on purpose — a native
-`<details>` (`data-keep-open`, or a ticking badge folds it shut over a
-half-typed address) around the shared `<.address_form>`, whose `change` event
-this page has to name for itself because `typing` already means the typing
-indicator here. Without Fediverse participation the box explains where the
-switch is instead of taking an address it could not send.
+Every other conversation here starts from somebody's page — a profile, an
+account page, a private answer under a post. `/messages` therefore carries a
+**finder** above the list, and it asks the member's real question ("who?")
+rather than ours ("on which server?"): one field, always on screen, that
+searches **both worlds at once**.
+
+  * **Members**, by first name, last name, both in either order, or a handle
+    (`Vutuv.Accounts.search_people/3`, which is where the composer's old
+    `Posts.search_users/3` question belongs; `SearchText.name_ilike/3` covers
+    the pair, and the reversed pair is asked for separately, because in a
+    German office "Petersen Jan" is as likely as "Jan Petersen").
+  * **Accounts on other networks this installation already holds**
+    (`Fediverse.search_accounts/2`) — rows we have because somebody follows
+    them, answered them or was answered by them. No request to anybody.
+  * **An address nobody here has met**, as one offered row: "Look this address
+    up". That is the only part that leaves the building, so it is a press of
+    its own, never something the page does while somebody types.
+
+Two characters before anything is searched, `phx-debounce="250"` on the field,
+and both halves are named in one line under it, because neither is guessable
+from a placeholder. Without Fediverse participation the finder says so and
+searches vutuv alone — a field that took an address it could not send would
+have wasted the typing.
 
 The two views link to each other **by anchor**, not merely to each other's
 page: `Fediverse.reply_anchor/1` for a note and `private_reply_anchor/1` for a

lib/vutuv/accounts.ex

@@ -2790,6 +2790,54 @@ defmodule Vutuv.Accounts do
   defp filter_flag(query, "spam"), do: where(query, [u], u.moderation_reason == "spam")
   defp filter_flag(query, _all), do: query
 
+  @doc """
+  Person typeahead: activated members matching `term`, `me` excluded, ordered
+  by name. Returns `[]` below two characters, so one keystroke never runs a
+  `%like%` over the whole table.
+
+  Matches a **first name, a last name, both in either order, or a handle** —
+  `SearchText.name_ilike/3` covers "Jan", "Petersen" and "Jan Petersen", and
+  the reversed pair is asked for separately because somebody looking for a
+  colleague types the name the way they hold it in their head, which in a
+  German office is as often "Petersen Jan".
+
+  It lives here rather than in the context that first needed it (`Vutuv.Posts`
+  grew one for the composer's "Hide from…" sheet): finding a member by name is
+  an Accounts question, and the messages page asks exactly the same one.
+  """
+  def search_people(%User{id: me_id}, term, limit \\ 8) when is_binary(term) do
+    term = String.trim(term)
+
+    if String.length(term) < 2 do
+      []
+    else
+      like = contains(term)
+      reversed = reversed_name(term)
+
+      Repo.all(
+        from(u in User,
+          where: u.id != ^me_id,
+          where: account_confirmed_row(u),
+          where:
+            name_ilike(u.first_name, u.last_name, ^like) or ilike(u.username, ^like) or
+              name_ilike(u.first_name, u.last_name, ^reversed),
+          order_by: [u.first_name, u.last_name],
+          limit: ^limit
+        )
+      )
+    end
+  end
+
+  # "Petersen Jan" as "Jan Petersen", so the pair matches whichever way round
+  # it was typed. Anything that is not exactly two words searches for itself
+  # twice, which costs nothing and keeps the query one shape.
+  defp reversed_name(term) do
+    case String.split(term, ~r/\s+/, trim: true) do
+      [first, last] -> contains(last <> " " <> first)
+      _other -> contains(term)
+    end
+  end
+
   defp search_members(query, nil), do: query
 
   defp search_members(query, term) do

lib/vutuv/fediverse.ex

@@ -1482,6 +1482,43 @@ defmodule Vutuv.Fediverse do
     end
   end
 
+  @doc """
+  Accounts on other networks this installation already holds, matching `term`
+  by display name, handle or address — the typeahead half of "write to
+  somebody out there", beside `remote_account_by_address/1`'s exact answer.
+
+  Nothing is asked of anybody: these are rows we have because somebody here
+  follows them, answered them or was answered by them. An address nobody here
+  has met is not found by this and is **resolved** instead, which costs a
+  request and a slot of the member's hourly budget and therefore stays a
+  deliberate act (`resolve_remote_account/2`).
+
+  Returns `[]` below two characters, like the member typeahead beside it.
+  """
+  def search_accounts(term, limit \\ 6) when is_binary(term) do
+    term = String.trim(term)
+
+    if String.length(term) < 2 do
+      []
+    else
+      base = from(a in RemoteAccount, order_by: [asc: a.handle, asc: a.id], limit: ^limit)
+
+      case browse_search_parts(term) do
+        {:handle_and_host, name, host} ->
+          Repo.all(where(base, [a], ilike(a.handle, ^name) and ilike(a.host, ^host)))
+
+        {:anywhere, like} ->
+          Repo.all(
+            where(
+              base,
+              [a],
+              ilike(a.name, ^like) or ilike(a.handle, ^like) or ilike(a.actor_uri, ^like)
+            )
+          )
+      end
+    end
+  end
+
   @doc """
   The stored remote accounts these actor URIs name, keyed by URI — one query
   for a whole page. A URI nobody here stored is simply absent, so callers

lib/vutuv_web/components/fediverse_components.ex

@@ -63,13 +63,6 @@ defmodule VutuvWeb.FediverseComponents do
   attr(:error, :any, default: nil, doc: "the reason the last submit came back with, or nil")
   attr(:event, :string, required: true, doc: "the phx-submit event the host handles")
 
-  attr(:change, :string,
-    default: "typing",
-    doc:
-      "the phx-change event; a host that already answers `typing` for something else " <>
-        "(the messages page's typing indicator) passes its own name instead"
-  )
-
   attr(:submit, :string, required: true, doc: "what the button says")
   attr(:variant, :string, default: "primary")
 
@@ -96,7 +89,7 @@ defmodule VutuvWeb.FediverseComponents do
     <form
       id={"#{@id}-form"}
       phx-submit={@event}
-      phx-change={@change}
+      phx-change="typing"
       class={["flex flex-wrap items-end gap-3", @class]}
     >
       <div class="min-w-56 grow">