fix: make password toggle button accessible and localised(WPB-21228) #19714

arjita-mitra · 2025-10-28T09:43:46Z

WPB-21228 [Web] Login - Text alternative of the control panel for hiding/showing passwords only available in English

Description

make password toggle button accessible and localised(WPB-21228)

Checklist

mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
PR has been self reviewed by the author;
Hard-to-understand areas of the code have been commented;
If it is a core feature, unit tests have been added;

github-actions · 2025-10-28T10:05:31Z

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

✅ Passed: 7
❌ Failed: 6
⏭ Skipped: 0
🔁 Flaky: 1
📊 Total: 14
⏱ Total Runtime: 1107.3s (~ 18 min 27 sec)

Failed Tests:

❌ Team owner adds whole team to an all team chat (tags: TC-8631, crit-flow-web)

Location: specs/CriticalFlow/addMembersToChat-TC-8631.spec.ts:43
Duration: 43833ms

Errors:

Error: expect(received).toBeTruthy()

Received: false

  141 |       // Owner verifies all messages are visible
  142 |       await pages.conversationList().openConversation(conversationName);
> 143 |       expect(await pages.conversation().isMessageVisible(`Hello from ${member1.firstName}!`)).toBeTruthy();
      |                                                                                               ^
  144 |       expect(await pages.conversation().isMessageVisible(`Hello from ${member2.firstName}!`)).toBeTruthy();
  145 |     });
  146 |
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/addMembersToChat-TC-8631.spec.ts:143:95
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/addMembersToChat-TC-8631.spec.ts:101:5

❌ Calls in channels with device switch and screenshare (tags: TC-8754, crit-flow-web)

Location: specs/CriticalFlow/channelsCall-TC-8755.spec.ts:39
Duration: 92359ms

Errors:

TimeoutError: locator.click: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name=\'go-audio-video\']')
    - locator resolved to <button type="button" class="left-list-item-button " data-uie-name="go-audio-video">…</button>
  - attempting click action
    2 × waiting for element to be visible, enabled and stable
      - element is visible, enabled and stable
      - scrolling into view if needed
      - done scrolling
      - <div tabindex="0" role="dialog" aria-modal="true" class=" css-1ocmba1" data-uie-name="modal-account-new-devices">…</div> from <div class="css-18o04gs">…</div> subtree intercepts pointer events
    - retrying click action
    - waiting 20ms
    2 × waiting for element to be visible, enabled and stable
      - element is visible, enabled and stable
      - scrolling into view if needed
      - done scrolling
      - <div tabindex="0" role="dialog" aria-modal="true" class=" css-1ocmba1" data-uie-name="modal-account-new-devices">…</div> from <div class="css-18o04gs">…</div> subtree intercepts pointer events
    - retrying click action
      - waiting 100ms
    38 × waiting for element to be visible, enabled and stable
       - element is visible, enabled and stable
       - scrolling into view if needed
       - done scrolling
       - <div tabindex="0" role="dialog" aria-modal="true" class=" css-1ocmba1" data-uie-name="modal-account-new-devices">…</div> from <div class="css-18o04gs">…</div> subtree intercepts pointer events
     - retrying click action
       - waiting 500ms


   at pageManager/webapp/pages/settings.page.ts:37

  35 |
  36 |   async clickAudioVideoSettingsButton() {
> 37 |     await this.audioVideoSettingsButton.click();
     |                                         ^
  38 |   }
  39 |
  40 |   async clickAccountButton() {
    at SettingsPage.clickAudioVideoSettingsButton (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/settings.page.ts:37:41)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsCall-TC-8755.spec.ts:121:35
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/channelsCall-TC-8755.spec.ts:119:5

❌ Planning group call with sending various messages during call (tags: TC-8632, crit-flow-web)

Location: specs/CriticalFlow/groupCalls-TC-8632.spec.ts:37
Duration: 31366ms

Errors:

Error: expect(received).toBeFalsy()

Received: true

  122 |       await memberCalling.unmuteSelfInFullScreen();
  123 |       await memberPageManager.waitForTimeout(250);
> 124 |       expect(await memberCalling.isSelfUserMutedInFullScreen()).toBeFalsy();
      |                                                                 ^
  125 |     });
  126 |
  127 |     await test.step('Validation: Owner sees member is unmuted', async () => {
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupCalls-TC-8632.spec.ts:124:65
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupCalls-TC-8632.spec.ts:121:5

❌ Group Video call (tags: TC-8637, crit-flow-web)

Location: specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:39
Duration: 29524ms

Errors:

Error: expect(page).toHaveTitle(expected) failed

Expected: "(1) Wire"
Received: "Wire"
Timeout:  10000ms

Call log:
  - Expect "toHaveTitle" with timeout 10000ms
    14 × unexpected value "Wire"


  115 |       await ownerModals.userProfile().clickConnectButton();
  116 |       expect(await ownerPages.conversationList().isConversationItemVisible(guestUser.fullName));
> 117 |       await expect(await guestPageManager.getPage()).toHaveTitle('(1) Wire');
      |                                                      ^
  118 |
  119 |       await guestPages.conversationList().openPendingConnectionRequest();
  120 |       await guestPages.connectRequest().clickConnectButton();
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:117:54
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/groupVideoCall-TC-8637.spec.ts:111:5

❌ New person joins team and setups up device (tags: TC-8635, crit-flow-web)

Location: specs/CriticalFlow/joinTeam-TC-8635.spec.ts:38
Duration: 67358ms

Errors:

TimeoutError: locator.waitFor: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('#add-participants [data-uie-name="search-list"] [aria-label="Open profile of Imani Weissnat"]').locator('input[type="checkbox"]')


   at pageManager/webapp/pages/conversationDetails.page.ts:66

  64 |       await userLocator.click();
  65 |       // Wait for the user to be selected (checkbox should be checked)
> 66 |       await userLocator.locator('input[type="checkbox"]').waitFor({state: 'attached'});
     |                                                           ^
  67 |     }
  68 |
  69 |     await this.page.locator(`${selectById('add-participants')} ${selectByDataAttribute('do-create')}`).click();
    at ConversationDetailsPage.addUsersToConversation (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/conversationDetails.page.ts:66:59)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/joinTeam-TC-8635.spec.ts:127:7
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/joinTeam-TC-8635.spec.ts:116:5

❌ Personal Account Lifecycle (tags: TC-8638, crit-flow-web)

Location: specs/CriticalFlow/personalAccountLifecycle-TC-8638.spec.ts:31
Duration: 35115ms

Errors:

TimeoutError: locator.waitFor: Timeout 20000ms exceeded.
Call log:
  - waiting for locator('[data-uie-name="label-with-email"]') to be visible


   at pageManager/webapp/pages/emailVerification.page.ts:68

  66 |
  67 |   async isEmailVerificationPageVisible() {
> 68 |     await this.verificationCodeInputLabel.waitFor({state: 'visible'});
     |                                           ^
  69 |     return true;
  70 |   }
  71 | }
    at EmailVerificationPage.isEmailVerificationPageVisible (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/pageManager/webapp/pages/emailVerification.page.ts:68:43)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/personalAccountLifecycle-TC-8638.spec.ts:72:44
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/personalAccountLifecycle-TC-8638.spec.ts:57:3

Flaky Tests:

⚠️ Account Management (tags: TC-8639, crit-flow-web)

Location: specs/CriticalFlow/accountManagement-TC-8639.spec.ts:37

Attempt 1
Result: ❌ Failed
Duration: 84758ms

Errors:

Error: Matching URL not found in the email body

   at backend/inbucketClient.e2e.ts:120

  118 |
  119 |     if (this.isValidURL(matchingUrl) === false) {
> 120 |       throw new Error('Matching URL not found in the email body');
      |             ^
  121 |     }
  122 |
  123 |     return matchingUrl;
    at InbucketClientE2E.getMatchingURLFromEmailBody (/home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/backend/inbucketClient.e2e.ts:120:13)
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/accountManagement-TC-8639.spec.ts:135:30
    at /home/runner/actions-runner/_work/wire-webapp/wire-webapp/test/e2e_tests/specs/CriticalFlow/accountManagement-TC-8639.spec.ts:126:3

Attempt 2
Result: ✅ Passed
Duration: 30004ms

…ubheading style adjustments

sonarqubecloud · 2025-11-13T10:25:54Z

Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fix: make password toggle button accessible and localised(WPB-21228)

d57105d

arjita-mitra requested review from a team and otto-the-bot as code owners October 28, 2025 09:43

otto-the-bot added type: bug / fix 🐞 👕 size: S labels Oct 28, 2025

arjita-mitra added 2 commits October 28, 2025 11:24

fix: translate type

9824fd1

fix: Login - New view is not announced

b49057b

otto-the-bot added 👕 size: M and removed 👕 size: S labels Oct 30, 2025

arjita-mitra added 6 commits October 30, 2025 14:12

fix: make back button accessible WPB-21466

2977e5b

fix: make external link 2fa accessible(WPB-21279)

0f935c0

fix: password toggle button text alternative(WPB-21228)

96e39ee

fix: make verify account header focusable using screenkey and login s…

18abd34

…ubheading style adjustments

Merge branch 'dev' into improv/accessibility-login-WPB-20819

7730cd4

fix: add toggle password show/hide label

7be324b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: make password toggle button accessible and localised(WPB-21228) #19714

fix: make password toggle button accessible and localised(WPB-21228) #19714

arjita-mitra commented Oct 28, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Oct 28, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Nov 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: make password toggle button accessible and localised(WPB-21228) #19714

Are you sure you want to change the base?

fix: make password toggle button accessible and localised(WPB-21228) #19714

Conversation

arjita-mitra commented Oct 28, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

github-actions bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 Playwright Test Summary

Failed Tests:

Flaky Tests:

Uh oh!

sonarqubecloud bot commented Nov 13, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

arjita-mitra commented Oct 28, 2025 •

edited by github-actions bot

Loading

github-actions bot commented Oct 28, 2025 •

edited

Loading