Linux Platform: fix the dispatch thread

GwendalRaoul · GwendalRaoul · commit 6a435a39fbe3 · 2025-02-21T16:51:48.000+01:00
In fact since a40af2f an old bug is now visible resulting in a 100% cpu usage. In case we exit the wait, if there is nothing in the queue, we must not release the lock as we are waiting again immediatelly.
diff --git a/lib/platform/linux/platform.c b/lib/platform/linux/platform.c
@@ -115,8 +115,6 @@ static void * dispatch_indication(void * unused)
             // Check if we wake up but nothing in queue
             if (m_queue_empty)
             {
-                // Release the lock
-                pthread_mutex_unlock(&m_queue_mutex);
                 // Continue to evaluate the stop condition
                 continue;
             }
@@ -245,7 +243,7 @@ static void * poll_for_indication(void * unused)
                 free_buffer_room = m_ind_queue_read - m_ind_queue_write;
             }
         }
-                  
+
         if (m_polling_thread_state_request == POLLING_THREAD_STOP_REQUESTED)
         {
             // In case we are about to stop, let's poll only one by one to have more chance to

Original file line number	Diff line number	Diff line change
`@@ -115,8 +115,6 @@ static void * dispatch_indication(void * unused)`
`115`	`115`	`// Check if we wake up but nothing in queue`
`116`	`116`	`if (m_queue_empty)`
`117`	`117`	`{`
`118`		`- // Release the lock`
`119`		`- pthread_mutex_unlock(&m_queue_mutex);`
`120`	`118`	`// Continue to evaluate the stop condition`
`121`	`119`	`continue;`
`122`	`120`	`}`
`@@ -245,7 +243,7 @@ static void * poll_for_indication(void * unused)`
`245`	`243`	`free_buffer_room = m_ind_queue_read - m_ind_queue_write;`
`246`	`244`	`}`
`247`	`245`	`}`
`248`		`-`
	`246`	`+`
`249`	`247`	`if (m_polling_thread_state_request == POLLING_THREAD_STOP_REQUESTED)`
`250`	`248`	`{`
`251`	`249`	`// In case we are about to stop, let's poll only one by one to have more chance to`