Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(ko): fix Markdown newline in reference/overrides.md #2632

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

trueberryless
Copy link
Contributor

@trueberryless trueberryless commented Nov 23, 2024

Description

Screenshot_20241123-143155.png

Copy link

changeset-bot bot commented Nov 23, 2024

⚠️ No Changeset found

Latest commit: ffeb5a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Nov 23, 2024
Copy link

netlify bot commented Nov 23, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit ffeb5a2
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6741d8ff6f05db0008aeeba5
😎 Deploy Preview https://deploy-preview-2632--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@trueberryless
Copy link
Contributor Author

@jsparkdev Do you mind reviewing this PR?

@astrobot-houston
Copy link
Collaborator

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
ko reference/overrides.md Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor

@jsparkdev jsparkdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trueberryless Good catch, thanks.

@jsparkdev jsparkdev merged commit 6757a77 into withastro:main Nov 23, 2024
16 checks passed
@trueberryless trueberryless deleted the trueberryless-patch-4 branch November 23, 2024 13:36
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Nov 26, 2024
* main:
  i18n(zh-cn): Update `plugins.mdx` (withastro#2638)
  Fix Safari VoiceOver issue (withastro#2633)
  i18n(fr): update `resources/plugins` (withastro#2631)
  i18n(fr): update `guides/overriding-components` & `reference/overrides` (withastro#2627)
  i18n(de): update `reference/overrides.md` (withastro#2625)
  i18n(de): update `guides/overriding-components.mdx` (withastro#2626)
  [ci] format
  i18n(de): update `resources/plugins.mdx` (withastro#2624)
  Update overrides.md (withastro#2632)
  i18n(ko-KR): update `overrides.md` (withastro#2629)
  i18n(ko-KR): update `overriding-components.mdx` (withastro#2628)
  i18n(ko-KR): update `plugins.mdx` (withastro#2630)
  Add my two new plugins to Starlight `resources/plugins.mdx` page (withastro#2595)
  Clarify how to override default components that use multiple slots. (withastro#2386)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants