Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StylableExports type duplication in core and runtime #2257

Open
tzachbon opened this issue Jan 10, 2022 · 0 comments
Open

StylableExports type duplication in core and runtime #2257

tzachbon opened this issue Jan 10, 2022 · 0 comments
Labels
tech debt Updates, upgrades, stale code and work-arounds types Typing related

Comments

@tzachbon
Copy link
Contributor

Proposal Description

Currently, there are "types" duplication in the core and in the runtime packages.
There should be a decision if core should be dependent on the runtime or vise-versa, or there should be a dedicated runtime-types package.

The current way can lead to more type duplication, type mismatch, and unexpected behaviors.

Additional Context

#2256 - touched on this topic.
@tzachbon tzachbon added tech debt Updates, upgrades, stale code and work-arounds types Typing related labels Jan 10, 2022
@tzachbon tzachbon mentioned this issue Jan 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt Updates, upgrades, stale code and work-arounds types Typing related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tzachbon