Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When canceling a tx, the canceled tx has not badge 'Deprecated' #1298

Open
pythcoiner opened this issue Sep 8, 2024 · 3 comments
Open

When canceling a tx, the canceled tx has not badge 'Deprecated' #1298

pythcoiner opened this issue Sep 8, 2024 · 3 comments
Labels
Enhancement Improving an existing functionality GUI gui related

Comments

@pythcoiner
Copy link
Collaborator

Before the cancel tx is mined
image

after the cancel tx mined:
image

shouldn't the canceled tx already appear deprecated before the cancel tx mined as the canceled tx not anymore in mempool?

@nondiremanuel nondiremanuel added GUI gui related Enhancement Improving an existing functionality labels Sep 9, 2024
@jp1ac4
Copy link
Collaborator

jp1ac4 commented Sep 12, 2024

I think we can only be sure it's Deprecated once the pending tx has been confirmed. Otherwise, we would have to try broadcasting it to see whether it can replace the pending tx or not.

Perhaps we could indicate that it conflicts with the pending tx and so the user knows it might not be possible to broadcast.

@pythcoiner
Copy link
Collaborator Author

hum, if it have been replaced in the mempool by the new one why, not considering it deprecated?

@jp1ac4
Copy link
Collaborator

jp1ac4 commented Sep 12, 2024

We don't currently keep track of replacements in the DB so I don't think there's an easy way for the GUI to know if one transaction has replaced another in the mempool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improving an existing functionality GUI gui related
Projects
None yet
Development

No branches or pull requests

3 participants