Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coin selection: no coins selected if the amount to send over balance amount #1326

Open
pythcoiner opened this issue Sep 12, 2024 · 4 comments
Labels
Glitch A small annoyance in the GUI that is not entirely a bug GUI gui related

Comments

@pythcoiner
Copy link
Collaborator

image
but BTC left to select amount looks correct

@nondiremanuel nondiremanuel added GUI gui related Glitch A small annoyance in the GUI that is not entirely a bug labels Sep 12, 2024
@jp1ac4
Copy link
Collaborator

jp1ac4 commented Sep 12, 2024

Currently, if there's an error due to insufficient funds, we don't make any changes to the selected coins.

But I think in such a case where no coins were previously selected, it would make sense to mark all coins as selected. However, there may be some coins shown that were not coin selection candidates (e.g. unconfirmed external deposits). So we would ideally have a way to know which coins had been used by lianad as coin selection candidates without repeating the logic, which could diverge over time.

@pythcoiner
Copy link
Collaborator Author

i thinks it's also fine to not select coins, but in this case we should display a warning "insufficient balance" instead wrong "xxx left to select"

@jp1ac4
Copy link
Collaborator

jp1ac4 commented Sep 13, 2024

Ah yes. I think that would be better.

There might be a situation where there's insufficient balance using coin selection, but sufficient balance if including some unconfirmed coins manually (if they're external deposits). Maybe we could add something to the message to allow for this possibility, but it would probably be too long and not required most of the time so I think your suggestion makes sense.

@nondiremanuel
Copy link
Collaborator

Related to #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Glitch A small annoyance in the GUI that is not entirely a bug GUI gui related
Projects
None yet
Development

No branches or pull requests

3 participants