From 035585501727eb5bc58eca908692c31ba723a436 Mon Sep 17 00:00:00 2001
From: Abban Dunne <abban.dunne@wikimedia.de>
Date: Mon, 7 Aug 2023 07:10:41 +0200
Subject: [PATCH] Make no-unused-vars an error in the linter

This is to make the CI fail when someone forgets
to remove a variable or import. It was defaulted to
warning only meaning some have been missed.
---
 .eslintrc.cjs                                                 | 4 ++++
 .../C23_WMDE_Desktop_DE_02/content/BannerSlidesVar.vue        | 2 +-
 .../desktop/C23_WMDE_Desktop_DE_02/content/BannerTextVar.vue  | 2 +-
 banners/desktop/content/BannerSlidesVar.vue                   | 2 +-
 banners/desktop/content/BannerTextVar.vue                     | 2 +-
 5 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/.eslintrc.cjs b/.eslintrc.cjs
index 96ed881e6..5b60d323c 100644
--- a/.eslintrc.cjs
+++ b/.eslintrc.cjs
@@ -23,6 +23,10 @@ module.exports = {
 		// TODO: Turn this rule back on when this is merged https://github.com/vuejs/eslint-plugin-vue/pull/2268
 		'vue/no-setup-props-destructure': [ 'off' ],
 
+		// Make unused vars throw a linter error
+		'no-unused-vars': 'off',
+		'@typescript-eslint/no-unused-vars': 'error',
+
 		// We want to use const and let wherever we like. TypeScript will inform us about use-before-declaration situations
 		'vars-on-top': [ 'off' ],
 
diff --git a/archive/desktop/C23_WMDE_Desktop_DE_02/content/BannerSlidesVar.vue b/archive/desktop/C23_WMDE_Desktop_DE_02/content/BannerSlidesVar.vue
index 3b01707d5..a47309ef6 100644
--- a/archive/desktop/C23_WMDE_Desktop_DE_02/content/BannerSlidesVar.vue
+++ b/archive/desktop/C23_WMDE_Desktop_DE_02/content/BannerSlidesVar.vue
@@ -30,7 +30,7 @@
 
 <script setup lang="ts">
 import { DynamicContent } from '@src/utils/DynamicContent/DynamicContent';
-import { computed, inject, ref } from 'vue';
+import { computed, inject } from 'vue';
 import InfoIcon from '@src/components/Icons/InfoIcon.vue';
 import KeenSliderSlide from '@src/components/Slider/KeenSliderSlide.vue';
 
diff --git a/archive/desktop/C23_WMDE_Desktop_DE_02/content/BannerTextVar.vue b/archive/desktop/C23_WMDE_Desktop_DE_02/content/BannerTextVar.vue
index ceb040831..4698ece35 100644
--- a/archive/desktop/C23_WMDE_Desktop_DE_02/content/BannerTextVar.vue
+++ b/archive/desktop/C23_WMDE_Desktop_DE_02/content/BannerTextVar.vue
@@ -19,7 +19,7 @@
 </template>
 
 <script setup lang="ts">
-import { computed, inject, ref } from 'vue';
+import { computed, inject } from 'vue';
 import { DynamicContent } from '@src/utils/DynamicContent/DynamicContent';
 import InfoIcon from '@src/components/Icons/InfoIcon.vue';
 
diff --git a/banners/desktop/content/BannerSlidesVar.vue b/banners/desktop/content/BannerSlidesVar.vue
index 3b01707d5..a47309ef6 100644
--- a/banners/desktop/content/BannerSlidesVar.vue
+++ b/banners/desktop/content/BannerSlidesVar.vue
@@ -30,7 +30,7 @@
 
 <script setup lang="ts">
 import { DynamicContent } from '@src/utils/DynamicContent/DynamicContent';
-import { computed, inject, ref } from 'vue';
+import { computed, inject } from 'vue';
 import InfoIcon from '@src/components/Icons/InfoIcon.vue';
 import KeenSliderSlide from '@src/components/Slider/KeenSliderSlide.vue';
 
diff --git a/banners/desktop/content/BannerTextVar.vue b/banners/desktop/content/BannerTextVar.vue
index ceb040831..4698ece35 100644
--- a/banners/desktop/content/BannerTextVar.vue
+++ b/banners/desktop/content/BannerTextVar.vue
@@ -19,7 +19,7 @@
 </template>
 
 <script setup lang="ts">
-import { computed, inject, ref } from 'vue';
+import { computed, inject } from 'vue';
 import { DynamicContent } from '@src/utils/DynamicContent/DynamicContent';
 import InfoIcon from '@src/components/Icons/InfoIcon.vue';