From c6485d7000aa7c98d0a610f0f3e8f0d5e5bce89f Mon Sep 17 00:00:00 2001 From: Corinna Hillebrand Date: Thu, 20 Jun 2024 17:36:49 +0200 Subject: [PATCH] Change CTRL banner for precampaign The first slide is removed from both banners. The feature of redirecting users directly to the payment providers is removed in both banners. The soft-close feature is removed/not used in both banners. The progress bar is removed from the modal/expanded banner in both banners. The campaign day sentence is removed/not used in both banners. The visitors-vs-donors sentence is removed/replaced in both banners. broken styles are fixed (wikipedia skin introduced some weird borders) The banners share the same height with the banner they are based on. https://phabricator.wikimedia.org/T366161 --- .../C24_WMDE_Mobile_DE_01/banner_var.ts | 2 +- .../components/BannerCtrl.vue | 53 +----- .../components/BannerVar.vue | 163 ++++++++++++++++++ .../components/FullPageBanner.vue | 1 - .../components/MiniBanner.vue | 1 - .../content/BannerSlides.vue | 25 +-- .../content/BannerText.vue | 17 +- .../content/BannerTextVar.vue | 49 ++++++ .../mobile/C24_WMDE_Mobile_DE_01/messages.ts | 2 - .../styles/FullPageBanner.scss | 1 + .../styles/MiniBanner.scss | 2 + .../C24_WMDE_Mobile_DE_01/styles/styles.scss | 2 - .../DonationForm/MultiStepDonation.scss | 1 + 13 files changed, 234 insertions(+), 85 deletions(-) create mode 100644 banners/mobile/C24_WMDE_Mobile_DE_01/components/BannerVar.vue create mode 100644 banners/mobile/C24_WMDE_Mobile_DE_01/content/BannerTextVar.vue diff --git a/banners/mobile/C24_WMDE_Mobile_DE_01/banner_var.ts b/banners/mobile/C24_WMDE_Mobile_DE_01/banner_var.ts index afa1c1148..a316249ea 100644 --- a/banners/mobile/C24_WMDE_Mobile_DE_01/banner_var.ts +++ b/banners/mobile/C24_WMDE_Mobile_DE_01/banner_var.ts @@ -3,7 +3,7 @@ import { createVueApp } from '@src/createVueApp'; import './styles/styles.scss'; import BannerConductor from '@src/components/BannerConductor/BannerConductor.vue'; -import Banner from './components/BannerCtrl.vue'; +import Banner from './components/BannerVar.vue'; import { UrlRuntimeEnvironment } from '@src/utils/RuntimeEnvironment'; import { WindowResizeHandler } from '@src/utils/ResizeHandler'; import PageWPORG from '@src/page/PageWPORG'; diff --git a/banners/mobile/C24_WMDE_Mobile_DE_01/components/BannerCtrl.vue b/banners/mobile/C24_WMDE_Mobile_DE_01/components/BannerCtrl.vue index b2229faf5..16b79b845 100644 --- a/banners/mobile/C24_WMDE_Mobile_DE_01/components/BannerCtrl.vue +++ b/banners/mobile/C24_WMDE_Mobile_DE_01/components/BannerCtrl.vue @@ -1,7 +1,7 @@ - - - - - - import { BannerStates } from '@src/components/BannerConductor/StateMachine/BannerStates'; -import SoftClose from '@src/components/SoftClose/SoftClose.vue'; import { computed, inject, ref, watch } from 'vue'; import FullPageBanner from './FullPageBanner.vue'; import MiniBanner from './MiniBanner.vue'; @@ -121,7 +90,6 @@ import ChevronLeftIcon from '@src/components/Icons/ChevronLeftIcon.vue'; import { CloseChoices } from '@src/domain/CloseChoices'; import { CloseEvent } from '@src/tracking/events/CloseEvent'; import { TrackingFeatureName } from '@src/tracking/TrackingEvent'; -import ProgressBar from '@src/components/ProgressBar/ProgressBar.vue'; import MainDonationFormPaymentMethodLabeledButton from '@src/components/DonationForm/Forms/MainDonationFormPaymentMethodLabeledButton.vue'; import { @@ -130,12 +98,10 @@ import { import { createSubmittableUpgradeToYearly } from '@src/components/DonationForm/StepControllers/SubmittableUpgradeToYearly'; -import { useAnonymousAddressTypeSetter } from '@src/components/composables/useAnonymousAddressTypeSetter'; enum ContentStates { Mini = 'wmde-banner-wrapper--mini', - FullPage = 'wmde-banner-wrapper--full-page', - SoftClosing = 'wmde-banner-wrapper--soft-closing' + FullPage = 'wmde-banner-wrapper--full-page' } enum FormStepNames { @@ -165,29 +131,14 @@ const stepControllers = [ createSubmittableUpgradeToYearly( formModel, FormStepNames.MainDonationFormStep, FormStepNames.MainDonationFormStep ) ]; -useAnonymousAddressTypeSetter(); - watch( contentState, async () => { emit( 'bannerContentChanged' ); } ); -function onCloseMiniBanner(): void { - if ( props.remainingImpressions > 0 ) { - contentState.value = ContentStates.SoftClosing; - } else { - onClose( 'MainBanner', CloseChoices.Close ); - } -} - function onClose( feature: TrackingFeatureName, userChoice: CloseChoices ): void { emit( 'bannerClosed', new CloseEvent( feature, userChoice ) ); } -function onSoftCloseClose( timer: number, feature: TrackingFeatureName, userChoice: CloseChoices ): void { - window.clearInterval( timer ); - onClose( feature, userChoice ); -} - function onshowFullPageBanner(): void { slideShowStopped.value = true; contentState.value = ContentStates.FullPage; diff --git a/banners/mobile/C24_WMDE_Mobile_DE_01/components/BannerVar.vue b/banners/mobile/C24_WMDE_Mobile_DE_01/components/BannerVar.vue new file mode 100644 index 000000000..14a8891f1 --- /dev/null +++ b/banners/mobile/C24_WMDE_Mobile_DE_01/components/BannerVar.vue @@ -0,0 +1,163 @@ + + + diff --git a/banners/mobile/C24_WMDE_Mobile_DE_01/components/FullPageBanner.vue b/banners/mobile/C24_WMDE_Mobile_DE_01/components/FullPageBanner.vue index 89eb818a4..973467b02 100644 --- a/banners/mobile/C24_WMDE_Mobile_DE_01/components/FullPageBanner.vue +++ b/banners/mobile/C24_WMDE_Mobile_DE_01/components/FullPageBanner.vue @@ -6,7 +6,6 @@
-
Jetzt sind Sie in Deutschland gefragt. diff --git a/banners/mobile/C24_WMDE_Mobile_DE_01/components/MiniBanner.vue b/banners/mobile/C24_WMDE_Mobile_DE_01/components/MiniBanner.vue index 851c00022..b8d3ea00a 100644 --- a/banners/mobile/C24_WMDE_Mobile_DE_01/components/MiniBanner.vue +++ b/banners/mobile/C24_WMDE_Mobile_DE_01/components/MiniBanner.vue @@ -14,7 +14,6 @@
-
diff --git a/banners/mobile/C24_WMDE_Mobile_DE_01/content/BannerSlides.vue b/banners/mobile/C24_WMDE_Mobile_DE_01/content/BannerSlides.vue index ffc10c1c8..fb14a32ff 100644 --- a/banners/mobile/C24_WMDE_Mobile_DE_01/content/BannerSlides.vue +++ b/banners/mobile/C24_WMDE_Mobile_DE_01/content/BannerSlides.vue @@ -1,11 +1,5 @@