-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codist Beta 7.3 #251
Comments
Thats cool. I can not test at the moment but looking into the code i understood that you identify the severity of the analyzers issue based on its text. Did i understood right? |
Yes, you are right. |
Yes i have a workaround solution.... As you can see this is showing IDE0090 as error. Because in editor config i have Its kind of workaround to get the values from the ErrorList service. There you can log all errors with their code and severity. So let me know it that suitable for you and i can provide a PR with my current code (it is not optimized but you can get the basic idea). |
I know about that workaround, years ago. It has limitations. For instance, I usually hide warning and information items in the Error List, thus those items will not be available from the API of the Error List. And it can be slow, if the list is quite long. Thus I don't want to take it. |
You are not right about some things.... How do you think the Microsoft's extension Solution Error Visualizer works without slowdown? It uses the ErrorList for that. But ofcource is your choice. :) |
It was a story years ago. Solution Error Visualizer was hiding warnings or errors if corresponding filters were disabled while I was using that extension. I no longer used that extension after upgraded to VS 2019 or 2022--I could not remember. Perhaps things got changed in recent versions of VS. Anyway, I found another way to deal with this problem without the Error List. |
What is that way? If you dont mind share it. |
Codist is open-sourced. |
OK. I wanted to know it earlier since i can use it in my other things i am developing, but anyway i will wait then. |
P.S. I hope your way will work even with external analyzers. ErrorList way works with them too ;) |
I noticed that recent versions of Codist reset the VS's bracket matching color to barely visible light gray. The fix is to go to VS Options, Fonts and Colors and to change the current color of the bracket matching and bracket matching rectangle to a different color. |
Cool. Generally it works. But have some issues... it show IDE0002 as suggestion. but it is actually hidden ;) |
Sorry about that. I think if I remember correctly you said a few months back that Codist might be doing this and you have fixed the issue, so I thought the issue has appeared again and assumed it to be Codist. I guess it is some kind of VS bug. |
About the "problem" above with not displaying correct severity.... There is a way to fix that..... However it involve some reflection since the required properties are not public... Well you didnt provide the code for your beta but i assume you use IErrorTag to retrieve the info. But IErrorTag provide publicly only the ErrorType which is different than the severity. But you can get the severity from a private property that contains DiagnosticData. in this way you get the correct severity. |
@DimitarCC |
But it mistake the severity. If you want the severity it is wrong. If you want to display type only is different story. |
Well OK.... Still parsing that values from the text of TooltipContent seems not so right. Its much more easier to get it from Severity property of DiagnosticData ;) |
Please try the new beta which has added more icon types for warning messages. |
Yes i have just tried it... |
OK they are some issues... Sometimes when the diagnostics messages are first in the tooltip it not render icons at all. |
Yes, I had met with this situation while I was working with my another project once. |
@fitdev |
I have found something else... |
Yes, it is really nice! Exactly what I was hoping for! Thank you for your work! The only suggestion is that it would be great if there was a way to visually distinguish some identifiers from regular xml doc text, because often for things like method names or property names, the font style is the same as regular text. Perhaps text editor's default font may be used for that? |
@DimitarCC |
@fitdev |
Yes, I agree, in your case they would look quite different and provide good contrast :), but not in my case... As you can see |
@fitdev |
@DimitarCC |
Well not really. It still doesnt work in some cases |
Now i can remove underline but can not ever return it back. So i ended up with no underlines at all. |
Sorry to see that. However, I could not find a way to reproduce this.
There's a logical mistake in the configuration window. I will fix it later. |
It is easy reproducible with your TestProgect2 -> CS11_0.cs -> line 66 end space (look at my screenshot before) The error comes here Because you loop over it from index 1 but the diagnostics info is in index 0. Maybe before there is some miss. I just track it till here. |
Yes, I have fixed that. |
I am using the latest code that you have committed before 9h (i have build it myself because i would like to change some icons you have used ;)) |
Yes. What kind of icons have you changed? |
aha. OK. |
I found a way to display the code symbols with the editor font in Quick Info. Only the XML Doc part will use the code editor font. |
That's great! Exactly what I was hoping for! |
@fitdev Please test the new beta. |
Works really well! Thank you so much for your work! |
The previous beta versions could cause some errors while editing code files. |
Using the latest beta and latest VS Preview 17.6 Preview 3, I got a crash when interacting with NaviBar:
|
@fitdev |
It happened once only when I was either clicking on it to get a dropdown menu or when I started typing in the search field in the resx designer generated cs file. |
@fitdev |
A new version is about to be publicly released. |
I noticed that the beta sometimes causes document syntax highlighting to momentarily (for a split-second) revert to VS's default when typing in the editor in the latest VS preview. Did not see it happen before. |
Thank you for reporting this. The new beta has also improved C# Quick Info to display info about LINQ expressions, and Super Syntax Highlight to highlight some brackets, operators and punctuations (part of #93). |
Thank you so much for a quick fix! So far it works a lot better and editor seems a lot more performant! |
The new version was just released. |
Download
Codist 8534
Codist 8524
Codist 8514
Codist 8501
Codist 8495
Codist 8493
Codist 8484
Codist 8477
Codist 8466
Codist 8461
Codist 8448
What's New
await
The text was updated successfully, but these errors were encountered: