Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default NGINX_BROTLI_COMP_LEVEL to big #40

Open
Punk-UnDeaD opened this issue Nov 22, 2019 · 1 comment
Open

default NGINX_BROTLI_COMP_LEVEL to big #40

Punk-UnDeaD opened this issue Nov 22, 2019 · 1 comment

Comments

@Punk-UnDeaD
Copy link

I think level 6 - not best idea.
It slower than gzip, also i can't use brotli_static and gzip together for static files.
I runed some tests and think than 2 - better level by default, response smaller than gziped and nginx work fast.
@Punk-UnDeaD Punk-UnDeaD changed the title default NGINX_BROTLI_COMP_LEVEL default NGINX_BROTLI_COMP_LEVEL to big Nov 22, 2019
@csandanov
Copy link
Member

csandanov commented Nov 25, 2019 •
edited
Loading

Hi, I agree we should set it lower because our default gzip comp level is currently 1. I would say we should also set it to 1, further optimizations depend on the CPU resources and the nature of the content.

Ref:

If we want to set it higher, brotli should be 5 (to enable context modeling) but gzip in this case should probably be around 8-9.

csandanov added a commit that referenced this issue Nov 25, 2019
@csandanov
Set brotli default comp level to 1 #40
8527e0c
esolitos pushed a commit to ramsalt/wodby--nginx that referenced this issue Feb 7, 2020
Merge remote-tracking branch 'upstream/master'
95a71b2 
* upstream/master: (25 commits)
  Update base image stability tag to 2.4.3
  Rebuild against updated base image
  Update nginx to 1.17.8
  Update base image stability tag to 2.4.2
  Rebuild against updated base image
  Update nginx to 1.17.7
  Update base image stability tag to 2.4.1
  Rebuild against updated base image
  Update base image stability tag to 2.4.0
  Rebuild against updated base image
  Forbid wodby.yml and Makefile
  Exclude .well-known from denied hidden files location instead of explicitly allowing it
  Set brotli default comp level to 1 wodby#40
  Update nginx to 1.17.6
  Add brotli compression wodby#37
  Update nginx to 1.17.5
  Update base image stability tag to 2.3.3
  Rebuild against updated base image
  Update nginx to 1.17.4
  Update base image stability tag to 2.3.2
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Punk-UnDeaD @csandanov