First sector fail fix #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test, this will cause the test to fail since a power failure here means the fw_size of boot will be missing
are swapped and therefore the fw_sizes are wrong
jpbland1
force-pushed
the
first-sector-fail
branch
2 times, most recently
from
b19d256
to
d4231f8
Compare
jpbland1
force-pushed
the
first-sector-fail
branch
from
d4231f8
to
fd03888
Compare
dgarske
approved these changes
Aug 15, 2023
dgarske
requested changes
Aug 15, 2023
src/update_flash.c
Outdated
| /* Use biggest size for the swap */ | ||
| total_size = boot->fw_size + IMAGE_HEADER_SIZE; | ||
| if ((update->fw_size + IMAGE_HEADER_SIZE) > total_size) | ||
| total_size = update->fw_size + IMAGE_HEADER_SIZE; |
src/update_flash.c
Outdated
| @@ -361,6 +361,19 @@ static int wolfBoot_delta_update(struct wolfBoot_image *boot, | |||
| #define MAX_UPDATE_SIZE (size_t)((WOLFBOOT_PARTITION_SIZE - (2 *WOLFBOOT_SECTOR_SIZE))) | |||
| #endif | |||
|
|
|||
| static int RAMFUNCTION wolfBoot_get_total_size(struct wolfBoot_image* boot, | |||
There was a problem hiding this comment.
Can we just make this inline and remove the RAMFUNCTION? static inline int?
dgarske
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZD 15415