Keep RNG seed file descriptor open until the RNG is freed. #7586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
reviewed
May 27, 2024
wolfcrypt/src/random.c
Outdated
Comment on lines
2034
to
2044
| if(rng->seed.fd != -1) { | ||
| close(rng->seed.fd); | ||
| } |
There was a problem hiding this comment.
Should this also reset rng->seed.fd = -1;?
There was a problem hiding this comment.
Great catch, it should indeed. Fixed.
|
Retest this please |
kareem-wolfssl
force-pushed
the
gh7197
branch
from
54b3613
to
1328b26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Keep RNG seed file descriptor open until the RNG is freed.
Fixes #7197
Testing
Built in tests
Checklist