Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with invalid recorded games #79

Open
schnapster opened this issue Dec 28, 2019 · 0 comments
Open

Deal with invalid recorded games #79

schnapster opened this issue Dec 28, 2019 · 0 comments
Labels
component:data Database, Redis, etc - how we save and deal with our data meta:nit-pick Stuff that looks important to devs but probably has minimal impact for users size:S Can probably be done in a day or two

Comments

@schnapster
Copy link
Member

There needs to be a way to deal with recorded games that turned out to be invalid.

As part of #78 some recorded games have been discovered that ended more than once. In that case, those with two recorded ending events are the invalid ones, but in other cases other rules might apply, so an automatic rule is hard to come up with. Rather they should be dealt with manually on a case-by-case basis.
Deleting them might be also be too destructive of an operation. I'd rather see them marked as invalid with a flag in the db, but that will also make any statistical queries rather complicated.

@schnapster schnapster added meta:nit-pick Stuff that looks important to devs but probably has minimal impact for users size:S Can probably be done in a day or two component:data Database, Redis, etc - how we save and deal with our data labels Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:data Database, Redis, etc - how we save and deal with our data meta:nit-pick Stuff that looks important to devs but probably has minimal impact for users size:S Can probably be done in a day or two
Projects
None yet
Development

No branches or pull requests

1 participant