Gitea/FJ: create branch before opening PR #273
Conversation
| @@ -37,6 +37,13 @@ export class GiteaForge extends Forge { | |||
| sourceBranch: string; | |||
| targetBranch: string; | |||
| }): Promise<{ pullRequestLink: string }> { | |||
| await this.handleApiErrors( | |||
There was a problem hiding this comment.
We already push changes (and thereby create a new branch with actual content) a few lines before, so this seems to be rather a hack that would not include those changes. Is gitea taking some time after pushing a branch to recognize it?
There was a problem hiding this comment.
We might have multiple issues: one for branch creation, one for PR creation.
For this one, when the branch is pushed/created, do we check for conflicts? I can't really infer where this is done. If it is a push, no conflicts should arise, if it an API call, it should be accounted for.
And yes, the "undefined" return in case of an API error should also be improved to at least see the underlying error.
|
Agree that this is not the issue. Will create a new, more comprehensive refactor PR soon which is more robust to the current issues at hand. |
fix #204
Untested, would test in
woodpecker-pluginswithnextto see if that solves the current issues there.