Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: move pipeline compilers getSecretValue() into an compiler Option #4378

Open
6543 opened this issue Nov 14, 2024 · 2 comments
Open

Refactor: move pipeline compilers getSecretValue() into an compiler Option #4378

6543 opened this issue Nov 14, 2024 · 2 comments
Labels
engine change how the pipeline engine works refactor delete or replace old code

Comments

@6543
Copy link
Member

6543 commented Nov 14, 2024 •
edited
Loading

woodpecker/pipeline/frontend/yaml/compiler/convert.go

Line 101 in 1c7728f

getSecretValue := func(name string) (string, error) {

woodpecker/pipeline/frontend/yaml/compiler/compiler.go

Line 97 in 1c7728f

secrets map[string]Secret

instead of definding on the fly func and passing al secrets onto the compiler, we can inject an function that can directly query the database ... and for cli the args etc...
@6543
Copy link
Member Author

6543 commented Nov 14, 2024

NOTE: if #3723 merged should als be done for it

@6543 6543 added refactor delete or replace old code engine change how the pipeline engine works labels Nov 14, 2024
@6543 6543 mentioned this issue Nov 14, 2024
Closed
@6543
Copy link
Member Author

6543 commented Nov 19, 2024

-> #4384 well a simple function wont do ... we should adjust and add a SecretService

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine change how the pipeline engine works refactor delete or replace old code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@6543