Noticed some inconsistent things, so far 3 apart from formatting (which should get resolved by #172) and 1 potential code quality issue.
- unks seems to have a mix of lowercase in name and arrays, uppercase in comments in some older code and everything uppercase in newer code
- in some places, doxygen comments seem to be used but majority of comments currently around the code seem to be just regular ones
- probably would be good to swap to doxygen comments, but this would need some discussion and probably a lot of changes
- CONTRIBUTING.md/Declare a new member section mentions removal of explicit alignment which may be harmful (but in majority of cases wasnt yet)
- I believe there should be some audit made to see what used to have some alignment specified and doesnt now, and discuss what to do with items that miss it now, as at least according to psiberx, they may not matter much for a lot of cases. Could be though because some other member enforces the alignment on including class (hence why some audit may be a good idea)
- constness should be revisited throughout the project, newer stuff tries to be const-correct where possible but some older code is not
- enums could be part of some larger header, we have a lot of headers containing only enums as i found out now, we could try some better grouping overall in the dumper
- name and aliases at least in dumped stuff from RTTI use const char* instead of string_view or const auto& or const char[], all of which offer known size and optimize some string-related operations better
Noticed some inconsistent things, so far 3 apart from formatting (which should get resolved by #172) and 1 potential code quality issue.