Skip to content

Commit 2829e55

Browse files
committed
Fix close button in CollapsableHeaderViewCon
1 parent a701af2 commit 2829e55

File tree

3 files changed

+14
-18
lines changed

3 files changed

+14
-18
lines changed

WordPress/Classes/Services/PageCoordinator.swift

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,12 @@ class PageCoordinator {
1414

1515
private static func showLayoutPicker(from controller: UIViewController, forBlog blog: Blog, _ completion: @escaping TemplateSelectionCompletion) {
1616
let rootViewController = GutenbergLayoutPickerViewController(blog: blog, completion: completion)
17-
let navigationController = GutenbergLightNavigationController(rootViewController: rootViewController)
17+
let navigationController: UINavigationController
18+
if #available(iOS 26, *) {
19+
navigationController = UINavigationController(rootViewController: rootViewController)
20+
} else {
21+
navigationController = GutenbergLightNavigationController(rootViewController: rootViewController)
22+
}
1823
navigationController.modalPresentationStyle = .pageSheet
1924

2025
controller.present(navigationController, animated: true, completion: nil)

WordPress/Classes/ViewRelated/Gutenberg/Collapsable Header/CollapsableHeaderViewController.swift

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -166,23 +166,9 @@ class CollapsableHeaderViewController: UIViewController, NoResultsViewHost {
166166

167167
// MARK: - Static Helpers
168168
public static func closeButton(target: Any?, action: Selector) -> UIBarButtonItem {
169-
let closeButton = UIButton(frame: CGRect(x: 0, y: 0, width: 30, height: 30))
170-
closeButton.layer.cornerRadius = 15
171-
closeButton.accessibilityLabel = NSLocalizedString("Close", comment: "Dismisses the current screen")
169+
let closeButton = UIBarButtonItem(barButtonSystemItem: .close, target: target, action: action)
172170
closeButton.accessibilityIdentifier = "close-button"
173-
closeButton.setImage(UIImage.gridicon(.crossSmall), for: .normal)
174-
closeButton.addTarget(target, action: action, for: .touchUpInside)
175-
176-
closeButton.tintColor = .secondaryLabel
177-
closeButton.backgroundColor = UIColor { (traitCollection: UITraitCollection) -> UIColor in
178-
if traitCollection.userInterfaceStyle == .dark {
179-
return UIColor.systemFill
180-
} else {
181-
return UIColor.quaternarySystemFill
182-
}
183-
}
184-
185-
return UIBarButtonItem(customView: closeButton)
171+
return closeButton
186172
}
187173

188174
// MARK: - Initializers

WordPress/Classes/ViewRelated/Site Creation/Design Selection/SiteDesignContentCollectionViewController.swift

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,12 @@ extension SiteDesignContentCollectionViewController: CategorySectionTableViewCel
340340
completion: completion
341341
)
342342

343-
let navController = GutenbergLightNavigationController(rootViewController: previewVC)
343+
let navigationController: UINavigationController
344+
if #available(iOS 26, *) {
345+
navigationController = UINavigationController(rootViewController: previewVC)
346+
} else {
347+
navigationController = GutenbergLightNavigationController(rootViewController: previewVC)
348+
}
344349
navController.modalPresentationStyle = .pageSheet
345350
navigationController?.present(navController, animated: true) {
346351
// deselect so no border is shown on dismissal of the preview

0 commit comments

Comments
 (0)