Make sleep time configurable in MetadataDownloader

This way, the tests can run fast, instead of waiting for the default 20s

Author: mokagio

lib/fastlane/plugin/wpmreleasetoolkit/helper/metadata_download_helper.rb

@@ -57,17 +57,21 @@ module Helper
     class MetadataDownloader
       attr_reader :target_folder, :target_files
 
-      def initialize(target_folder, target_files, auto_retry)
+      def initialize(target_folder, target_files, auto_retry, auto_retry_sleep_time = 20, auto_retry_max_attempts = 30)
         @target_folder = target_folder
         @target_files = target_files
         @auto_retry = auto_retry
+        @auto_retry_sleep_time = auto_retry_sleep_time
         @alternates = {}
         @auto_retry_attempt_counter = 0
       end
 
       # Downloads data from GlotPress, in JSON format
       def download(target_locale, glotpress_url, is_source)
-        downloader = GlotPressDownloader.new(auto_retry: @auto_retry)
+        downloader = GlotpressDownloader.new(
+          auto_retry: @auto_retry,
+          auto_retry_sleep_time: @auto_retry_sleep_time
+        )
         response = downloader.download(glotpress_url)
         handle_glotpress_download(response: response, locale: target_locale, is_source: is_source)
       end

spec/metadata_download_helper_spec.rb

@@ -8,7 +8,8 @@
           metadata_downloader = described_class.new(
             tmp_dir,
             { key: { desc: 'target-file-name.txt' } },
-            true
+            true,
+            0.1
           )
 
           fake_url = 'https://test.com'
@@ -24,7 +25,7 @@
           end
 
           expect(Fastlane::UI).to receive(:message)
-            .with(/Received 429 for `#{fake_url}`. Auto retrying in 20 seconds.../)
+            .with(/Received 429 for `#{fake_url}`. Auto retrying in 0.1 seconds.../)
 
           expect(Fastlane::UI).to receive(:message)
             .with(/No translation available for en-AU/)
@@ -34,7 +35,7 @@
 
           metadata_downloader.download('en-AU', fake_url, false)
 
-          expect(count).to eq(2)
+          assert_requested(:get, fake_url, times: 2)
         end
       end
     end