diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_localize_project.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_localize_project.rb deleted file mode 100644 index d443799ac..000000000 --- a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_localize_project.rb +++ /dev/null @@ -1,43 +0,0 @@ -module Fastlane - module Actions - class IosLocalizeProjectAction < Action - def self.run(params) - UI.message 'Updating project localisation...' - - require_relative '../../helper/ios/ios_git_helper' - other_action.cocoapods() - Fastlane::Helper::Ios::GitHelper.localize_project() - - UI.message 'Done.' - end - - ##################################################### - # @!group Documentation - ##################################################### - - def self.description - 'Gathers the strings to localise. Deprecated' - end - - def self.details - 'Gathers the strings to localise. Deprecated in favor of the new `ios_generate_strings_file_from_code`' - end - - def self.category - :deprecated - end - - def self.deprecated_notes - 'This action is deprecated in favor of `ios_generate_strings_file_from_code`' - end - - def self.authors - ['loremattei'] - end - - def self.is_supported?(platform) - platform == :ios - end - end - end -end diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_update_metadata.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_update_metadata.rb deleted file mode 100644 index 084c9d6b8..000000000 --- a/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_update_metadata.rb +++ /dev/null @@ -1,40 +0,0 @@ -module Fastlane - module Actions - class IosUpdateMetadataAction < Action - def self.run(params) - require_relative '../../helper/ios/ios_git_helper' - - Fastlane::Helper::Ios::GitHelper.update_metadata() - end - - ##################################################### - # @!group Documentation - ##################################################### - - def self.description - 'Downloads translated metadata from the translation system' - end - - def self.details - 'Downloads translated metadata from the translation system' - end - - def self.available_options - end - - def self.output - end - - def self.return_value - end - - def self.authors - ['loremattei'] - end - - def self.is_supported?(platform) - platform == :ios - end - end - end -end diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_git_helper.rb b/lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_git_helper.rb index 01909b8c1..77cdc1d2f 100644 --- a/lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_git_helper.rb +++ b/lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_git_helper.rb @@ -28,48 +28,6 @@ def self.commit_version_bump(include_deliverfile: true, include_metadata: true) Fastlane::Helper::GitHelper.commit(message: 'Bump version number', files: files_list, push: true) end - # Calls the `Scripts/localize.py` script in the project root folder and push the `*.strings` files - # - # That script updates the `.strings` files with translations from GlotPress. - # - # @env PROJECT_ROOT_FOLDER The path to the git root of the project - # @env PROJECT_NAME The name of the directory containing the project code (especially containing the `build.gradle` file) - # - # @deprecated This method is only used by the `ios_localize_project` action, which is itself deprecated - # in favor of the new `ios_generate_strings_file_from_code` action - # @todo [Next Major] Remove this method once we fully remove `ios_localize_project` - # - def self.localize_project - Action.sh("cd #{get_from_env!(key: 'PROJECT_ROOT_FOLDER')} && ./Scripts/localize.py") - - Fastlane::Helper::GitHelper.commit(message: 'Update strings for localization', files: strings_files, push: true) || UI.message('No new strings, skipping commit') - end - - # Call the `Scripts/update-translations.rb` then the `fastlane/download_metadata` Scripts from the host project folder - # - # @env PROJECT_ROOT_FOLDER The path to the git root of the project - # @env PROJECT_NAME The name of the directory containing the project code (especially containing the `build.gradle` file) - # - # @todo Migrate the scripts, currently in each host repo and called by this method, to be helpers and actions - # in the release-toolkit instead, and move this code away from `ios_git_helper`. - # - def self.update_metadata - Action.sh("cd #{get_from_env!(key: 'PROJECT_ROOT_FOLDER')} && ./Scripts/update-translations.rb") - - Fastlane::Helper::GitHelper.commit(message: 'Update translations', files: strings_files, push: false) - - Action.sh('cd fastlane && ./download_metadata.swift') - - Fastlane::Helper::GitHelper.commit(message: 'Update metadata translations', files: './fastlane/metadata/', push: true) - end - - def self.strings_files - project_root = get_from_env!(key: 'PROJECT_ROOT_FOLDER') - project_name = get_from_env!(key: 'PROJECT_NAME') - - Dir.glob(File.join(project_root, project_name, '**', '*.strings')) - end - def self.get_from_env!(key:) ENV.fetch(key) do UI.user_error! "Could not find value for \"#{key}\" in environment."