Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot all figures from the book #4

Closed
paulobruno opened this issue Apr 15, 2022 · 2 comments
Closed

Plot all figures from the book #4

paulobruno opened this issue Apr 15, 2022 · 2 comments
Labels
newfeature New feature or request

Comments

@paulobruno
Copy link
Collaborator

Although the standard figures are currently implemented and at least very close to the original ones, implementing all of them (including the parameter variations) would increase the confidence that the current code is indeed in pair with the original.

@paulobruno paulobruno added the newfeature New feature or request label Sep 13, 2022
@natema
Copy link
Member

natema commented Sep 27, 2022

I opened #76 regarding how we are currently reproducing the figures.

paulobruno added a commit that referenced this issue Sep 28, 2022
While we don't finish some figures of chapter 7, it's better to have
an empty function that will inform the user some figures are not yet
implemented.

Related to #4
@paulobruno
Copy link
Collaborator Author

I was a naive young guy when I created this issue 😅
Even after more than five months, we don't have all of the figures implemented.
Since we handled most of them and only very few are missing, I'll close this issue and we'll deal specific cases on their own issues.

@paulobruno paulobruno added this to the Reproducing World3 milestone Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
newfeature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants