Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention in the documentation parameter discrepancies between book and code #59

Open
universmile opened this issue Sep 20, 2022 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@universmile
Copy link
Contributor

universmile commented Sep 20, 2022

It might be useful to enhance the documentation of some parameters (with the book as a reference), that would act as a sanity check and help ensure that some inconsistencies (e.g., Issue #60) are not caused by a parameter discrepancy between the code and the book.

For example :

  • In Chapter 2, instead of 1900, 1970, and 2100, the authors use 0, 70, and 200, respectively. Thus, the unit of lt is years.
  • By looking at the source code in Chapter 7 (cf. screenshot below), we see that ppgf2 is a constant (= 1). Instead, if we look at Chapter 6, ppgf2 is a switch. This had led to an instability perceived in Figure 7.20, which was fixed (thanks to @paulobruno) by setting that the change on variable ppgf2 in the book corresponds to ppgf21 in the code.
pol_parameters_7_20 = World3.Pollution.getparameters()
pol_parameters_7_20[:ppgf21] = 0.1

dynamo_7_20

@natema natema added this to the reproducing World3 milestone Sep 21, 2022
@natema natema added the documentation Improvements or additions to documentation label Sep 21, 2022
paulobruno added a commit that referenced this issue Sep 27, 2022
paulobruno added a commit that referenced this issue Sep 27, 2022
@paulobruno paulobruno changed the title Parameters sanity check Mention in the documentation parameter discrepancies between book and code Oct 5, 2022
@paulobruno paulobruno removed this from the reproducing World3 milestone Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants