Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing data & placeholder #70

Closed
HenryQuan opened this issue May 15, 2022 · 2 comments
Closed

Missing data & placeholder #70

HenryQuan opened this issue May 15, 2022 · 2 comments
Assignees
@HenryQuan
Labels
enhancement

Comments

@HenryQuan
Copy link
Member

There are missing icons in acheivement now. I think we will encounter more similar issues. A fallback solution is needed. We can either display nothing or use the app icon as the placeholder.
@HenryQuan HenryQuan self-assigned this May 15, 2022
@HenryQuan
Copy link
Member Author

We should decide whether we handle it from the app or remove those entries while generating the data.
wowsinfo/WoWs-Game-Data#9

@HenryQuan
Copy link
Member Author

This is no longer a problem with the latest data repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HenryQuan HenryQuan

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HenryQuan