Skip to content

Commit fde49e2

Browse files
committed
Code changes after review
1 parent 9bcee70 commit fde49e2

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

_includes/components/search_header.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
<search class="search">
2-
<form class="search-input-wrap" action="{{ site.baseurl }}/search/" method="get">
1+
<section class="search" aria-label="Search">
2+
<form class="search-input-wrap" role="search" action="{{ site.baseurl }}/search/" method="get">
33
<label for="search-input" class="search-label">
44
<span class="screen-reader-text">Search {{ site.title }}</span>
55
<svg viewBox="0 0 24 24" class="search-icon" aria-hidden="true">
@@ -19,4 +19,4 @@
1919
</form>
2020

2121
<div id="search-results" class="search-results"></div>
22-
</search>
22+
</section>

_includes/components/sidebar.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
<header class="site-header">
33

44
<div class="lh-wrapper">
5-
<a href="{{ '/' | relative_url }}" class="site-title lh-tight">
6-
<img src="{{site.baseurl}}/assets/images/logo-wa11ypuu.png" alt="WP Accessibility logo, to homepage">
5+
<a href="{{ '/' | relative_url }}" class="site-title lh-tight" aria-label="WP Accessibility logo, to the homepage">
6+
<img src="{{site.baseurl}}/assets/images/logo-wa11ypuu.png" alt="WP Accessibility logo">
77
{{ site.title }}
88
</a>
99
</div>

_sass/layout/_navigation.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
font-size: var(--text-font-size-sm);
2020
font-weight: 300;
2121
margin: 0;
22+
min-height: 48px;
2223
display: flex;
2324
flex-wrap: wrap;
2425
align-items: center;
@@ -104,7 +105,6 @@
104105

105106
.nav-list-item {
106107
position: relative;
107-
min-height: 48px;
108108

109109
.nav-list-link {
110110
color: $nav-child-link-color;

0 commit comments

Comments
 (0)