From fc505f5eb6240509547717c0f0676b33b383f527 Mon Sep 17 00:00:00 2001 From: Anthony Islas Date: Tue, 27 May 2025 16:00:21 -0700 Subject: [PATCH 1/3] Correct syntax with explicit function arguments where previously implicit --- external/RSL_LITE/rsl_bcast.c | 2 +- external/io_grib1/MEL_grib1/pack_spatial.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/external/RSL_LITE/rsl_bcast.c b/external/RSL_LITE/rsl_bcast.c index 28c6725d7e..7b823f076d 100755 --- a/external/RSL_LITE/rsl_bcast.c +++ b/external/RSL_LITE/rsl_bcast.c @@ -82,7 +82,7 @@ static int destroy_par_info ( p ) static int destroy_list( list, dfcn ) rsl_list_t ** list ; /* pointer to pointer to list */ - int (*dfcn)() ; /* pointer to function for destroying + int (*dfcn)(void *) ; /* pointer to function for destroying the data field of the list */ { rsl_list_t *p, *trash ; diff --git a/external/io_grib1/MEL_grib1/pack_spatial.c b/external/io_grib1/MEL_grib1/pack_spatial.c index de5f64c069..ddca6b8b48 100644 --- a/external/io_grib1/MEL_grib1/pack_spatial.c +++ b/external/io_grib1/MEL_grib1/pack_spatial.c @@ -88,7 +88,7 @@ int pack_spatial ( pt_cnt, bit_cnt, pack_null, fbuff, ppbitstream, float max_grid; /* maximum value in grid */ float ftemp; /* temporary float containing grid value */ unsigned long *pBitstream; - unsigned long grib_local_ibm(); + unsigned long grib_local_ibm(double local_float); int wordnum; int zero_cnt; int prec_too_high = 0; From f30ec9b8b571b35c32b7e39cf3b5f6194bc55b76 Mon Sep 17 00:00:00 2001 From: Anthony Islas Date: Fri, 30 May 2025 11:18:15 -0700 Subject: [PATCH 2/3] Realign comments --- external/RSL_LITE/rsl_bcast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/external/RSL_LITE/rsl_bcast.c b/external/RSL_LITE/rsl_bcast.c index 7b823f076d..50f664b2ef 100755 --- a/external/RSL_LITE/rsl_bcast.c +++ b/external/RSL_LITE/rsl_bcast.c @@ -82,7 +82,7 @@ static int destroy_par_info ( p ) static int destroy_list( list, dfcn ) rsl_list_t ** list ; /* pointer to pointer to list */ - int (*dfcn)(void *) ; /* pointer to function for destroying + int (*dfcn)(void *) ; /* pointer to function for destroying the data field of the list */ { rsl_list_t *p, *trash ; From 7a1bff4b4fb6a16e5c71d0d473b3e70b6c6628ae Mon Sep 17 00:00:00 2001 From: Anthony Islas Date: Fri, 30 May 2025 11:19:09 -0700 Subject: [PATCH 3/3] Simplify function declaration to minimum required --- external/io_grib1/MEL_grib1/pack_spatial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/external/io_grib1/MEL_grib1/pack_spatial.c b/external/io_grib1/MEL_grib1/pack_spatial.c index ddca6b8b48..3868436f78 100644 --- a/external/io_grib1/MEL_grib1/pack_spatial.c +++ b/external/io_grib1/MEL_grib1/pack_spatial.c @@ -88,7 +88,7 @@ int pack_spatial ( pt_cnt, bit_cnt, pack_null, fbuff, ppbitstream, float max_grid; /* maximum value in grid */ float ftemp; /* temporary float containing grid value */ unsigned long *pBitstream; - unsigned long grib_local_ibm(double local_float); + unsigned long grib_local_ibm(double); int wordnum; int zero_cnt; int prec_too_high = 0;