From 48236f7c30da269c391addc54bd754aa1dd5af3c Mon Sep 17 00:00:00 2001 From: dakshina Date: Tue, 15 Oct 2024 12:37:43 +0530 Subject: [PATCH] Make broker connection failures NULL safe --- .../adapter/jms/internal/util/JMSConnectionFactory.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/components/event-publisher/event-output-adapters/org.wso2.carbon.event.output.adapter.jms/src/main/java/org/wso2/carbon/event/output/adapter/jms/internal/util/JMSConnectionFactory.java b/components/event-publisher/event-output-adapters/org.wso2.carbon.event.output.adapter.jms/src/main/java/org/wso2/carbon/event/output/adapter/jms/internal/util/JMSConnectionFactory.java index 4f6747dcea..7e4b51f0aa 100644 --- a/components/event-publisher/event-output-adapters/org.wso2.carbon.event.output.adapter.jms/src/main/java/org/wso2/carbon/event/output/adapter/jms/internal/util/JMSConnectionFactory.java +++ b/components/event-publisher/event-output-adapters/org.wso2.carbon.event.output.adapter.jms/src/main/java/org/wso2/carbon/event/output/adapter/jms/internal/util/JMSConnectionFactory.java @@ -285,9 +285,8 @@ public JMSPooledConnectionHolder getConnectionFromPool() { try { return (JMSPooledConnectionHolder) this.connectionPool.borrowObject(); } catch (Exception e) { - log.error(e.getMessage(), e); + throw new OutputEventAdapterRuntimeException("Error in getting JMS connection from pool", e); } - return null; } @@ -366,10 +365,8 @@ public Object makeObject() throws Exception { entry.setProducer(producer); return entry; } catch (JMSException e) { - log.error(e.getMessage(), e); - return null; + throw new OutputEventAdapterRuntimeException("Error creating JMS connection holder from JMS CF : " + name, e); } - } @Override