-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No guava dependencies #197
Conversation
@@ -293,8 +294,8 @@ | |||
<artifactId>maven-compiler-plugin</artifactId> | |||
<version>3.5.1</version> | |||
<configuration> | |||
<source>1.8</source> | |||
<target>1.8</target> | |||
<source>11</source> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as of we are mentioning that most recent version of our plugin requires Java 11, to be able to write code in Java 11 I decided to update it also
src/main/java/com/cognifide/aemrules/htl/lex/ElementTokenizer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cognifide/aemrules/java/checks/ThreadSafeFieldCheck.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
Should also take care of #199 |
This is an attempt for eliminating Guava related runtime errors like in #190
Improved 2 things:
26-jre
com.google.*
Regardless Guava version provided by Sonar, our plugin should work fine.