Skip to content

Commit 2fd9ff8

Browse files
authored
Merge pull request numpy#15653 from mattip/openblas0.3.7
BLD: update OpenBLAS to pre-0.3.9 version
2 parents e180d2a + eeb9e50 commit 2fd9ff8

6 files changed

+14
-16
lines changed

.travis.yml

-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ stages:
2929

3030
env:
3131
global:
32-
- OpenBLAS_version=0.3.8
3332
- WHEELHOUSE_UPLOADER_USERNAME=travis.numpy
3433
# The following is generated with the command:
3534
# travis encrypt -r numpy/numpy WHEELHOUSE_UPLOADER_SECRET=tH3AP1KeY

azure-pipelines.yml

+2-6
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@ trigger:
55
include:
66
- master
77
- maintenance/*
8-
variables:
9-
# OpenBLAS_version should be updated
10-
# to match numpy-wheels repo
11-
OpenBLAS_version: 0.3.8
128

139
stages:
1410
- stage: InitialTests
@@ -47,7 +43,7 @@ stages:
4743
echo CFLAGS \$CFLAGS && \
4844
python3 -m pip install -v . && \
4945
python3 runtests.py -n --debug-info --mode=full -- -rsx --junitxml=junit/test-results.xml && \
50-
python3 tools/openblas_support.py --check_version $(OpenBLAS_version)"
46+
python3 tools/openblas_support.py --check_version"
5147
displayName: 'Run 32-bit manylinux2010 Docker Build / Tests'
5248
- task: PublishTestResults@2
5349
condition: succeededOrFailed()
@@ -138,7 +134,7 @@ stages:
138134
displayName: 'Run Refuide Check'
139135
- script: python runtests.py -n --mode=full -- -rsx --junitxml=junit/test-results.xml
140136
displayName: 'Run Full NumPy Test Suite'
141-
- bash: python tools/openblas_support.py --check_version $(OpenBLAS_version)
137+
- bash: python tools/openblas_support.py --check_version
142138
displayName: 'Verify OpenBLAS version'
143139
- task: PublishTestResults@2
144140
condition: succeededOrFailed()

shippable.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ build:
5050
- extra_path=$(printf "%s:" "${extra_directories[@]}")
5151
- export PATH="${extra_path}${PATH}"
5252
# check OpenBLAS version
53-
- python tools/openblas_support.py --check_version 0.3.8
53+
- python tools/openblas_support.py --check_version
5454
# run the test suite
5555
- python runtests.py -n --debug-info --show-build-log -- -rsx --junit-xml=$SHIPPABLE_REPO_DIR/shippable/testresults/tests.xml -n 2 --durations=10
5656

tools/openblas_support.py

+9-6
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
import zipfile
1010
import tarfile
1111

12-
OPENBLAS_V = 'v0.3.8'
13-
OPENBLAS_LONG = 'v0.3.5-605-gc815b8fb' # the 0.3.5 is misleading
12+
OPENBLAS_V = '0.3.9'
13+
OPENBLAS_LONG = 'v0.3.7-391-gddcbed66' # the 0.3.7 is misleading
1414
BASE_LOC = 'https://anaconda.org/multibuild-wheels-staging/openblas-libs'
1515
BASEURL = f'{BASE_LOC}/{OPENBLAS_LONG}/download'
1616
ARCHITECTURES = ['', 'windows', 'darwin', 'aarch64', 'x86', 'ppc64le', 's390x']
@@ -243,8 +243,11 @@ def test_version(expected_version, ilp64=get_ilp64()):
243243
get_config.restype=ctypes.c_char_p
244244
res = get_config()
245245
print('OpenBLAS get_config returned', str(res))
246-
check_str = b'OpenBLAS %s' % expected_version[0].encode()
247-
assert check_str in res
246+
if not expected_version:
247+
expected_version = OPENBLAS_V
248+
check_str = b'OpenBLAS %s' % expected_version.encode()
249+
print(check_str)
250+
assert check_str in res, '%s not found in %s' %(expected_version, res)
248251
if ilp64:
249252
assert b"USE64BITINT" in res
250253
else:
@@ -257,10 +260,10 @@ def test_version(expected_version, ilp64=get_ilp64()):
257260
'architecture')
258261
parser.add_argument('--test', nargs='*', default=None,
259262
help='Test different architectures. "all", or any of %s' % ARCHITECTURES)
260-
parser.add_argument('--check_version', nargs=1, default=None,
263+
parser.add_argument('--check_version', nargs='?', default='',
261264
help='Check provided OpenBLAS version string against available OpenBLAS')
262265
args = parser.parse_args()
263-
if args.check_version is not None:
266+
if args.check_version != '':
264267
test_version(args.check_version)
265268
elif args.test is None:
266269
print(setup_openblas())

tools/pypy-test.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,4 @@ pypy3/bin/pypy3 runtests.py --debug-info --show-build-log -v -- -rsx \
4545
echo Make sure the correct openblas has been linked in
4646

4747
pypy3/bin/pip install .
48-
pypy3/bin/pypy3 tools/openblas_support.py --check_version "$OpenBLAS_version"
48+
pypy3/bin/pypy3 tools/openblas_support.py --check_version

tools/travis-test.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ run_test()
9797
export PYTHONWARNINGS=default
9898

9999
if [ -n "$CHECK_BLAS" ]; then
100-
$PYTHON ../tools/openblas_support.py --check_version $OpenBLAS_version
100+
$PYTHON ../tools/openblas_support.py --check_version
101101
fi
102102

103103
if [ -n "$RUN_FULL_TESTS" ]; then

0 commit comments

Comments
 (0)