Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add support for all response fields #12

Open
Bluenix2 opened this issue Apr 9, 2022 · 0 comments
Open

Re-add support for all response fields #12

Bluenix2 opened this issue Apr 9, 2022 · 0 comments
Labels
enhancement Improvement of an existing feature minor Deprecate, remove, or add a feature wumpy-interactions

Comments

@Bluenix2
Copy link
Collaborator

Bluenix2 commented Apr 9, 2022 •
edited
Loading

Summary

In 452f684 not all response fields was added for simplicity at the time. These should now be re-added to the interaction subclasses, see c16c998 (this file specifically) where they were originally removed.

The code for this should be in Interaction.respond() and not Request. Note the code probably cannot be directly copied back, it needs to be adapted for recent changes.

This will only support link components, there needs to be more architectural changes to support interactive components.
@Bluenix2 Bluenix2 added enhancement Improvement of an existing feature minor Deprecate, remove, or add a feature labels Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of an existing feature minor Deprecate, remove, or add a feature wumpy-interactions
Projects
Planning and triaging for a stable release
Status: 📁 - Planning
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bluenix2