Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel types in annotations #2

Open
Bluenix2 opened this issue Oct 12, 2021 · 1 comment
Open

Channel types in annotations #2

Bluenix2 opened this issue Oct 12, 2021 · 1 comment
Labels
enhancement Improvement of an existing feature help wanted Extra attention is needed minor Deprecate, remove, or add a feature wumpy-interactions

Comments

@Bluenix2
Copy link
Collaborator

Bluenix2 commented Oct 12, 2021 •
edited
Loading

Summary

This issue is opened to request help and ideas for how to support Discord's new channel_types field on Application command options.

Description

The problem isn't implementing channel_types - that is rather trivial with how the library has been structured - it's how to support it in a good API.

The easiest way is to add a keyword argument to the Option default and decorator that accepts an enum but if possible I would like to explore a way to use annotations.
@Bluenix2 Bluenix2 mentioned this issue Oct 12, 2021
Open
26 tasks
@Bluenix2 Bluenix2 added the help wanted Extra attention is needed label Oct 12, 2021
@Bluenix2 Bluenix2 changed the title Channel types Channel types in annotations Oct 12, 2021
@Bluenix2 Bluenix2 added enhancement Improvement of an existing feature minor Deprecate, remove, or add a feature labels Oct 12, 2021
@Bluenix2
Copy link
Collaborator Author

Bluenix2 commented Apr 9, 2022

This is no longer such a big problem since wumpy-models has been fleshed out, there now exists channel classes that can be used. wumpy-interactions should detect a Union of these to specify the channel types using Option.determine_union(). PR is welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of an existing feature help wanted Extra attention is needed minor Deprecate, remove, or add a feature wumpy-interactions
Projects
Planning and triaging for a stable release
Status: 🖨️ - Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bluenix2