Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relation between _pdbx_struct_special_symmetry.auth_asym_id and _atom_site.auth_asym_id #26

Open
drlemmus opened this issue Sep 30, 2020 · 6 comments

Comments

@drlemmus
Copy link

The relation between _pdbx_struct_special_symmetry.auth_asym_id and _atom_site.auth_asym_id is not properly described in dictionary which means that a change of _atom_site.auth_asym_id (e.g. from 'AAA' to 'A') cannot be inherited automatically.

@drlemmus
Copy link
Author

drlemmus commented Oct 1, 2020

Similarly, for pdbx_distant_solvent_atoms.auth_asym_id the connection to _atom_site.auth_asym_id is not working because the line "_item_linked.parent_name '_atom_site.auth_asym_id'" is commented out. Is there a good reason for this? This makes editing mmCIF files much harder.

@epeisach
Copy link
Contributor

In short, I do not know the historical reasons, but a number of attributes in pdbx_struct_special_symmetry.auth_asym_id are linked to chem_comp and struct_asym. One would need to review the archive to see if there is an issue here.

@drlemmus
Copy link
Author

Not quite sure what you mean. Do you want to check the archive to see if there are currently conflicts in the reference from _pdbx_struct_special_symmetry.auth_asym_id to _atom_site.auth_asym_id? Isn't that a reversal of the problem? We should see what is logical (IMO having the relation described) and then make sure the annotation fits the logic.

@epeisach
Copy link
Contributor

What I meant is that if we were to consider such a parent/child connection - we would need to review the archive to see if there are any conflicts. There is one dictionary for the archive. If we add a parent/child relationship - no matter how obvious, we need to ensure that there isn't an example that would violate it. If there is, we need to understand why.

@drlemmus
Copy link
Author

Yes, I agree. I was more considering the order of precedence. If anything, there are already entries in the archive that do not fit the dictionary. We just report them and they get fixed. It's a different story if this affects a lot of entries.

@epeisach
Copy link
Contributor

epeisach commented Jul 7, 2021

There are a few entries that have dictionary errors due to special circumstances. Symmetry operator shorthand n_abc - breaks down when you are close to a screw axis and need to exceed 9 for a or b or c. Non-homogeneous X-ray structures is another case.

What I was saying is that I do not wish to intentionally add a parent/child relationship which invalidates existing entries. The order is fix first before adding a restriction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants