Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color preferences don't seem to match the categories in the colorization list box #2005

Closed
robert-dodier opened this issue Mar 25, 2025 · 6 comments

Comments

@robert-dodier
Copy link
Collaborator

I'm working with wxMaxima built from Git (commit 96d54eb) on Ubuntu 16.04 + wxwidgets 3.2.5.

I am changing the color scheme via Edit >> Preferences >> Style and then choosing a category from the list box on the left side and then choosing a color using the color picker. Then I close the preferences and go back to the notebook view.

The categories in the list box don't see to correspond to items in the notebook. I've observed the following.

(1) Title, Section, and Subsection change the color of the numbers of sections and subsections, but not the text. Instead the text of titles, sections, and subsections is governed by "Code Default (Maxima input)".

(2) When set_display('ascii) has been called, output cells are colored by "ASCII maths" and "Standard text"; none of the "Output: ..." categories seem to apply. The line containing the output label is colored by "Standard text" and the remainder of the output is colored by "ASCII maths".

I guess "ASCII maths" is OK, but it seems like the output label line (aside from the output label itself) should also be colored according to "ASCII maths", not "Standard text".

I'm more than a little confused by the names of the colorization categories, although that's less of an issue. Ideally, I think, it would be clear what the different categories apply to. I won't try to spell it out here; let's just get through the mismatched colors, and then circle back about the labels if we get through that.

@robert-dodier
Copy link
Collaborator Author

Also, when set_display('ascii) is in effect, font size for output is governed by the font size of "Math Default", but the color is governed by the colors for "ASCII maths" and "Standard Text" as described above.

@gunterkoenigsmann
Copy link
Member

As you already have guessed if maxima is instructed to output everything as ascii it no more provides wxMaxima with hints on the nature of the text it currently outputs. All that could be done in that case is heuristics - and heuristics are bound to get surprising results, sooner or later.

Will try to find out where in TextCell the other colorization issues lie.

@gunterkoenigsmann
Copy link
Member

Ok... ...seems like the color issue is in Cell::SetTextColor.

@robert-dodier
Copy link
Collaborator Author

To be clear, when set_display(ascii) is in effect, I don't expect Maxima output to be colorized in the usual way; I expected all of it is governed by "ASCII maths". But, in addition to the heading color problem, there are other errors as described above.

@gunterkoenigsmann
Copy link
Member

The category names confuse me every time, too. But I don't have good ideas for better names, here. But the rest of the issues I will try to work on.

@robert-dodier
Copy link
Collaborator Author

I've rebuilt wxMaxima with the most recent version (b4f741), and it looks like the correct font and color are applied for title and section texts, thanks for fixing it.

I've copied the other stuff to a separate ticket (#2007) so I'll go ahead and close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants