fix: Reduce extension environment footprint #1231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1231 +/- ##
==========================================
- Coverage 80.59% 80.29% -0.30%
==========================================
Files 127 127
Lines 6090 6089 -1
Branches 1024 1022 -2
==========================================
- Hits 4908 4889 -19
- Misses 1167 1185 +18
Partials 15 15 ☔ View full report in Codecov by Sentry. |
|
Right now, this fix doesn't work because entrypoints are imported in parallel, and there's race-conditions that prevent the environment polyfills from being cleaned up properly. Need to wait for #1207 before this can be fixed. |
|
Closing this in favor of #1207. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #931. This fixes #1227.
Before, the extension environment polyfills were setup before creating the vite dev server. This was creating a
documentglobal that shouldn't exist when the dev-server is spinning up. Instead, the environment has been moved to have as small of a impact as possible - just when the entrypoint files are imported.