-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate button for selecting and deselecting the reset. #23
Comments
What is the problem to set it to 1? |
If setting it to 1 wipes the phone on the first wrong password, the description is misleading. As I understand it, "maximum number of" includes the number. If there is a sign that says "Maximum number of apples you can take is 10", you are not stealing when you take 10 apples. The description should be something like: "Number of wrong attempts at which point the phone gets wiped" |
OK, I will rename it to the same as API |
The wording of the API is strange because the number of attempts should be the minimum or exact number required to trigger a wipe, not the maximum. The changed wording is better and understandable, but I would just remove "Maximum" and call it: "Failed password attempts for wipe" if you want to stay closer to the official wording. |
I will think of it. |
It is possible to prevent the app from resetting the phone if the maximum number of attempts is set to 0, but this is not described anywhere and not intuitive. It also prevents you from wiping the phone on one wrong attempt.
I think it would be better to have a separate button that selects the reset.
The text was updated successfully, but these errors were encountered: