diff --git a/dotnet/Makefile b/dotnet/Makefile index 52de01a52f3b..baf46cec555c 100644 --- a/dotnet/Makefile +++ b/dotnet/Makefile @@ -58,7 +58,7 @@ $(foreach platform,$(DOTNET_WINDOWS_PLATFORMS),$(eval $(call DefineWindowsTarget ifdef INCLUDE_HOTRESTART iOS_WINDOWS_NUGET_TARGETS += \ - $(DOTNET_DESTDIR)/$(IOS_NUGET_WINDOWS_SDK_NAME)/tools/msbuild/Xamarin.PreBuilt.iOS.app.zip \ + $(DOTNET_DESTDIR)/$(IOS_NUGET_WINDOWS_SDK_NAME)/tools/msbuild/iOS/Xamarin.PreBuilt.iOS.app.zip \ endif @@ -507,7 +507,7 @@ clean-local:: $(Q) $(DOTNET) restore package/workaround-for-maccore-issue-2427/restore.csproj /bl:package/workaround-for-maccore-issue-2427/restore.binlog $(MSBUILD_VERBOSITY) $(Q) touch $@ -$(DOTNET_DESTDIR)/$(IOS_NUGET_WINDOWS_SDK_NAME)/tools/msbuild/Xamarin.PreBuilt.iOS.app.zip: .stamp-install-workloads +$(DOTNET_DESTDIR)/$(IOS_NUGET_WINDOWS_SDK_NAME)/tools/msbuild/iOS/Xamarin.PreBuilt.iOS.app.zip: .stamp-install-workloads $(Q) $(MAKE) -C $(TOP)/msbuild/Xamarin.HotRestart.PreBuilt all $(Q) touch $@ diff --git a/dotnet/Workloads/SignList.xml b/dotnet/Workloads/SignList.xml index f90d7e6391eb..fae12d42c701 100644 --- a/dotnet/Workloads/SignList.xml +++ b/dotnet/Workloads/SignList.xml @@ -3,17 +3,17 @@ - - - - - - - - - - - + + + + + + + + + + + diff --git a/mk/xamarin-reset.sh b/mk/xamarin-reset.sh index c4f41bc7418a..24bbff6d448c 100755 --- a/mk/xamarin-reset.sh +++ b/mk/xamarin-reset.sh @@ -39,10 +39,10 @@ if test -d "$DEPENDENCY_PATH"; then fi else - echo "*** [$DEPENDENCY_NAME] git $DEPENDENCY_AUTH clone $DEPENDENCY_MODULE --recursive $DEPENDENCY_DIRECTORY -b $DEPENDENCY_BRANCH --origin $DEPENDENCY_REMOTE" + echo "*** [$DEPENDENCY_NAME] git" "${DEPENDENCY_AUTH[@]}" "clone $DEPENDENCY_MODULE --recursive $DEPENDENCY_DIRECTORY -b $DEPENDENCY_BRANCH --origin $DEPENDENCY_REMOTE" mkdir -p "$(dirname "$DEPENDENCY_PATH")" cd "$(dirname "$DEPENDENCY_PATH")" - git $DEPENDANCY_AUTH clone "$DEPENDENCY_MODULE" --recursive "$DEPENDENCY_DIRECTORY" -b "$DEPENDENCY_BRANCH" --origin "$DEPENDENCY_REMOTE" + git "$DEPENDENCY_AUTH" "$DEPENDENCY_MODULE" --recursive "$DEPENDENCY_DIRECTORY" -b "$DEPENDENCY_BRANCH" --origin "$DEPENDENCY_REMOTE" cd "$DEPENDENCY_DIRECTORY" fi diff --git a/src/rgen/Microsoft.Macios.Generator/DataModel/Accessor.cs b/src/rgen/Microsoft.Macios.Generator/DataModel/Accessor.cs index d126df718696..55df56b24810 100644 --- a/src/rgen/Microsoft.Macios.Generator/DataModel/Accessor.cs +++ b/src/rgen/Microsoft.Macios.Generator/DataModel/Accessor.cs @@ -44,7 +44,7 @@ public bool Equals (Accessor other) var attrsComparer = new AttributesEqualityComparer (); if (!attrsComparer.Equals (Attributes, other.Attributes)) return false; - var modifiersComparer = new ModifiersComparer (); + var modifiersComparer = new ModifiersEqualityComparer (); return modifiersComparer.Equals (Modifiers, other.Modifiers); } diff --git a/src/rgen/Microsoft.Macios.Generator/DataModel/AccessorsEqualityComparer.cs b/src/rgen/Microsoft.Macios.Generator/DataModel/AccessorsEqualityComparer.cs index 787bddab8a9b..a460fea45325 100644 --- a/src/rgen/Microsoft.Macios.Generator/DataModel/AccessorsEqualityComparer.cs +++ b/src/rgen/Microsoft.Macios.Generator/DataModel/AccessorsEqualityComparer.cs @@ -5,8 +5,8 @@ namespace Microsoft.Macios.Generator.DataModel; -class AccessorsEqualityComparer : IEqualityComparer> { - public bool Equals (ImmutableArray x, ImmutableArray y) +class AccessorsEqualityComparer : EqualityComparer> { + public override bool Equals (ImmutableArray x, ImmutableArray y) { // property accessor kinds cannot be duplicated due to the definition of the language, create two dictionaries // using the kind as a key and then re-use our dictionary comparer @@ -16,7 +16,7 @@ public bool Equals (ImmutableArray x, ImmutableArray y) return comparer.Equals (xDictionary, yDictionary); } - public int GetHashCode (ImmutableArray obj) + public override int GetHashCode (ImmutableArray obj) { var hashCode = new HashCode (); foreach (var accessor in obj) { diff --git a/src/rgen/Microsoft.Macios.Generator/DataModel/AttributesEqualityComparer.cs b/src/rgen/Microsoft.Macios.Generator/DataModel/AttributesEqualityComparer.cs index c4760c7d14c1..da83529093eb 100644 --- a/src/rgen/Microsoft.Macios.Generator/DataModel/AttributesEqualityComparer.cs +++ b/src/rgen/Microsoft.Macios.Generator/DataModel/AttributesEqualityComparer.cs @@ -30,9 +30,9 @@ public int Compare (AttributeCodeChange x, AttributeCodeChange y) return 0; } } -class AttributesEqualityComparer : IEqualityComparer> { +class AttributesEqualityComparer : EqualityComparer> { - public bool Equals (ImmutableArray x, ImmutableArray y) + public override bool Equals (ImmutableArray x, ImmutableArray y) { if (x.Length != y.Length) return false; @@ -46,7 +46,7 @@ public bool Equals (ImmutableArray x, ImmutableArray obj) + public override int GetHashCode (ImmutableArray obj) { var hash = new HashCode (); foreach (var change in obj) { diff --git a/src/rgen/Microsoft.Macios.Generator/DataModel/CodeChangesEqualityComparer.cs b/src/rgen/Microsoft.Macios.Generator/DataModel/CodeChangesEqualityComparer.cs index e4dd817fec43..b1f59c240860 100644 --- a/src/rgen/Microsoft.Macios.Generator/DataModel/CodeChangesEqualityComparer.cs +++ b/src/rgen/Microsoft.Macios.Generator/DataModel/CodeChangesEqualityComparer.cs @@ -4,26 +4,28 @@ namespace Microsoft.Macios.Generator.DataModel; -class DeclarationCodeChangesEqualityComparer : IEqualityComparer<(BaseTypeDeclarationSyntax Declaration, CodeChanges +class DeclarationCodeChangesEqualityComparer : EqualityComparer<(BaseTypeDeclarationSyntax Declaration, CodeChanges Changes)> { readonly CodeChangesEqualityComparer comparer = new (); - public bool Equals ((BaseTypeDeclarationSyntax Declaration, CodeChanges Changes) x, + /// + public override bool Equals ((BaseTypeDeclarationSyntax Declaration, CodeChanges Changes) x, (BaseTypeDeclarationSyntax Declaration, CodeChanges Changes) y) { return comparer.Equals (x.Changes, y.Changes); } - public int GetHashCode ((BaseTypeDeclarationSyntax Declaration, CodeChanges Changes) obj) + /// + public override int GetHashCode ((BaseTypeDeclarationSyntax Declaration, CodeChanges Changes) obj) => comparer.GetHashCode (obj.Changes); } /// /// Custom code changes comparer used for the Roslyn code generation to invalidate caching. /// -class CodeChangesEqualityComparer : IEqualityComparer { +class CodeChangesEqualityComparer : EqualityComparer { /// - public bool Equals (CodeChanges x, CodeChanges y) + public override bool Equals (CodeChanges x, CodeChanges y) { // things that mean a code change is the same: // - the fully qualified symbol is the same @@ -74,7 +76,7 @@ public bool Equals (CodeChanges x, CodeChanges y) } /// - public int GetHashCode (CodeChanges obj) + public override int GetHashCode (CodeChanges obj) { return HashCode.Combine (obj.FullyQualifiedSymbol, obj.EnumMembers); } diff --git a/src/rgen/Microsoft.Macios.Generator/DataModel/Constructor.cs b/src/rgen/Microsoft.Macios.Generator/DataModel/Constructor.cs index 771ab8da354b..28ae013ea2ef 100644 --- a/src/rgen/Microsoft.Macios.Generator/DataModel/Constructor.cs +++ b/src/rgen/Microsoft.Macios.Generator/DataModel/Constructor.cs @@ -68,7 +68,7 @@ public bool Equals (Constructor other) var attrsComparer = new AttributesEqualityComparer (); if (!attrsComparer.Equals (Attributes, other.Attributes)) return false; - var modifiersComparer = new ModifiersComparer (); + var modifiersComparer = new ModifiersEqualityComparer (); if (!modifiersComparer.Equals (Modifiers, other.Modifiers)) return false; diff --git a/src/rgen/Microsoft.Macios.Generator/DataModel/ConstructorsEqualityComparer.cs b/src/rgen/Microsoft.Macios.Generator/DataModel/ConstructorsEqualityComparer.cs index d6f3fa2224a9..8d27fdf125ea 100644 --- a/src/rgen/Microsoft.Macios.Generator/DataModel/ConstructorsEqualityComparer.cs +++ b/src/rgen/Microsoft.Macios.Generator/DataModel/ConstructorsEqualityComparer.cs @@ -5,8 +5,9 @@ namespace Microsoft.Macios.Generator.DataModel; -class ConstructorsEqualityComparer : IEqualityComparer> { - public bool Equals (ImmutableArray x, ImmutableArray y) +class ConstructorsEqualityComparer : EqualityComparer> { + /// + public override bool Equals (ImmutableArray x, ImmutableArray y) { // group the constructors based on the number of parameters. We create two dictionaries, that will have // the number of params as the key, and a list of constructors as the value @@ -19,7 +20,8 @@ public bool Equals (ImmutableArray x, ImmutableArray y return dictionaryComparer.Equals (xConstructors, yConstructors); } - public int GetHashCode (ImmutableArray obj) + /// + public override int GetHashCode (ImmutableArray obj) { var hashCode = new HashCode (); foreach (var ctr in obj) { diff --git a/src/rgen/Microsoft.Macios.Generator/DataModel/EnumMembersEqualityComparer.cs b/src/rgen/Microsoft.Macios.Generator/DataModel/EnumMembersEqualityComparer.cs index 6476664a7374..7f759f8b9cc0 100644 --- a/src/rgen/Microsoft.Macios.Generator/DataModel/EnumMembersEqualityComparer.cs +++ b/src/rgen/Microsoft.Macios.Generator/DataModel/EnumMembersEqualityComparer.cs @@ -5,9 +5,10 @@ namespace Microsoft.Macios.Generator.DataModel; -class EnumMembersEqualityComparer : IEqualityComparer> { +class EnumMembersEqualityComparer : EqualityComparer> { - public bool Equals (ImmutableArray x, ImmutableArray y) + /// + public override bool Equals (ImmutableArray x, ImmutableArray y) { if (x.Length != y.Length) return false; @@ -20,7 +21,8 @@ public bool Equals (ImmutableArray x, ImmutableArray y) return true; } - public int GetHashCode (ImmutableArray obj) + /// + public override int GetHashCode (ImmutableArray obj) { var hash = new HashCode (); foreach (var change in obj) { diff --git a/src/rgen/Microsoft.Macios.Generator/DataModel/Event.cs b/src/rgen/Microsoft.Macios.Generator/DataModel/Event.cs index c577ccdc8b62..f3935b46d8e7 100644 --- a/src/rgen/Microsoft.Macios.Generator/DataModel/Event.cs +++ b/src/rgen/Microsoft.Macios.Generator/DataModel/Event.cs @@ -58,7 +58,7 @@ public bool Equals (Event other) if (!attrsComparer.Equals (Attributes, other.Attributes)) return false; - var modifiersComparer = new ModifiersComparer (); + var modifiersComparer = new ModifiersEqualityComparer (); if (!modifiersComparer.Equals (Modifiers, other.Modifiers)) return false; diff --git a/src/rgen/Microsoft.Macios.Generator/DataModel/EventEqualityComparer.cs b/src/rgen/Microsoft.Macios.Generator/DataModel/EventEqualityComparer.cs index 088a81409fcd..bee09b9e1736 100644 --- a/src/rgen/Microsoft.Macios.Generator/DataModel/EventEqualityComparer.cs +++ b/src/rgen/Microsoft.Macios.Generator/DataModel/EventEqualityComparer.cs @@ -5,9 +5,10 @@ namespace Microsoft.Macios.Generator.DataModel; -class EventEqualityComparer : IEqualityComparer> { +class EventEqualityComparer : EqualityComparer> { - public bool Equals (ImmutableArray x, ImmutableArray y) + /// + public override bool Equals (ImmutableArray x, ImmutableArray y) { // properties are unique by their name, that means that we can build two dicts and comparethem var xDictionary = Enumerable.ToDictionary (x, property => property.Name); @@ -17,7 +18,8 @@ public bool Equals (ImmutableArray x, ImmutableArray y) return comparer.Equals (xDictionary, yDictionary); } - public int GetHashCode (ImmutableArray obj) + /// + public override int GetHashCode (ImmutableArray obj) { var hash = new HashCode (); foreach (var property in obj) { diff --git a/src/rgen/Microsoft.Macios.Generator/DataModel/Method.cs b/src/rgen/Microsoft.Macios.Generator/DataModel/Method.cs index be9b887cc8a7..8b1ed44e3730 100644 --- a/src/rgen/Microsoft.Macios.Generator/DataModel/Method.cs +++ b/src/rgen/Microsoft.Macios.Generator/DataModel/Method.cs @@ -80,7 +80,7 @@ public bool Equals (Method other) var attrsComparer = new AttributesEqualityComparer (); if (!attrsComparer.Equals (Attributes, other.Attributes)) return false; - var modifiersComparer = new ModifiersComparer (); + var modifiersComparer = new ModifiersEqualityComparer (); if (!modifiersComparer.Equals (Modifiers, other.Modifiers)) return false; diff --git a/src/rgen/Microsoft.Macios.Generator/DataModel/MethodsEqualityComparer.cs b/src/rgen/Microsoft.Macios.Generator/DataModel/MethodsEqualityComparer.cs index 015c595aabe6..ffd3bad75f02 100644 --- a/src/rgen/Microsoft.Macios.Generator/DataModel/MethodsEqualityComparer.cs +++ b/src/rgen/Microsoft.Macios.Generator/DataModel/MethodsEqualityComparer.cs @@ -5,9 +5,9 @@ namespace Microsoft.Macios.Generator.DataModel; -class MethodsEqualityComparer : IEqualityComparer> { +class MethodsEqualityComparer : EqualityComparer> { /// - public bool Equals (ImmutableArray x, ImmutableArray y) + public override bool Equals (ImmutableArray x, ImmutableArray y) { // to compare two lists, we need to do the following: // 1. Group all the methods by return type + name + param count, this way we @@ -27,7 +27,7 @@ public bool Equals (ImmutableArray x, ImmutableArray y) } /// - public int GetHashCode (ImmutableArray obj) + public override int GetHashCode (ImmutableArray obj) { var hashCode = new HashCode (); foreach (var ctr in obj) { diff --git a/src/rgen/Microsoft.Macios.Generator/DataModel/ModifiersComparer.cs b/src/rgen/Microsoft.Macios.Generator/DataModel/ModifiersEqualityComparer.cs similarity index 70% rename from src/rgen/Microsoft.Macios.Generator/DataModel/ModifiersComparer.cs rename to src/rgen/Microsoft.Macios.Generator/DataModel/ModifiersEqualityComparer.cs index 13b897fa4559..80eb3030da42 100644 --- a/src/rgen/Microsoft.Macios.Generator/DataModel/ModifiersComparer.cs +++ b/src/rgen/Microsoft.Macios.Generator/DataModel/ModifiersEqualityComparer.cs @@ -6,8 +6,9 @@ namespace Microsoft.Macios.Generator.DataModel; -public class ModifiersComparer : IEqualityComparer> { - public bool Equals (ImmutableArray x, ImmutableArray y) +public class ModifiersEqualityComparer : EqualityComparer> { + /// + public override bool Equals (ImmutableArray x, ImmutableArray y) { if (x.Length != y.Length) return false; @@ -21,7 +22,8 @@ public bool Equals (ImmutableArray x, ImmutableArray y return true; } - public int GetHashCode (ImmutableArray obj) + /// + public override int GetHashCode (ImmutableArray obj) { var hash = new HashCode (); foreach (var token in obj) { diff --git a/src/rgen/Microsoft.Macios.Generator/DataModel/ParameterEqualityComparer.cs b/src/rgen/Microsoft.Macios.Generator/DataModel/ParameterEqualityComparer.cs index 65e55dd835d4..563adb3e40f3 100644 --- a/src/rgen/Microsoft.Macios.Generator/DataModel/ParameterEqualityComparer.cs +++ b/src/rgen/Microsoft.Macios.Generator/DataModel/ParameterEqualityComparer.cs @@ -5,10 +5,10 @@ namespace Microsoft.Macios.Generator.DataModel; -class ParameterEqualityComparer : IEqualityComparer> { +class ParameterEqualityComparer : EqualityComparer> { /// - public bool Equals (ImmutableArray x, ImmutableArray y) + public override bool Equals (ImmutableArray x, ImmutableArray y) { // we know as a fact that parameter names have to be unique, otherwise we could not // compile the code. So make sure that all the parameters with the same name are the same @@ -20,7 +20,7 @@ public bool Equals (ImmutableArray x, ImmutableArray y) } /// - public int GetHashCode (ImmutableArray obj) + public override int GetHashCode (ImmutableArray obj) { var hashCode = new HashCode (); foreach (var constructor in obj) { diff --git a/src/rgen/Microsoft.Macios.Generator/DataModel/PropertiesEqualityComparer.cs b/src/rgen/Microsoft.Macios.Generator/DataModel/PropertiesEqualityComparer.cs index c7dbd4fe42fc..4428001df0d5 100644 --- a/src/rgen/Microsoft.Macios.Generator/DataModel/PropertiesEqualityComparer.cs +++ b/src/rgen/Microsoft.Macios.Generator/DataModel/PropertiesEqualityComparer.cs @@ -5,8 +5,9 @@ namespace Microsoft.Macios.Generator.DataModel; -class PropertiesEqualityComparer : IEqualityComparer> { - public bool Equals (ImmutableArray x, ImmutableArray y) +class PropertiesEqualityComparer : EqualityComparer> { + /// + public override bool Equals (ImmutableArray x, ImmutableArray y) { // properties are unique by their name, that means that we can build two dicts and comparethem var xDictionary = Enumerable.ToDictionary (x, property => property.Name); @@ -16,7 +17,8 @@ public bool Equals (ImmutableArray x, ImmutableArray y) return comparer.Equals (xDictionary, yDictionary); } - public int GetHashCode (ImmutableArray obj) + /// + public override int GetHashCode (ImmutableArray obj) { var hash = new HashCode (); foreach (var property in obj) { diff --git a/src/rgen/Microsoft.Macios.Generator/DataModel/Property.cs b/src/rgen/Microsoft.Macios.Generator/DataModel/Property.cs index a689df8409a5..6a8ff5cfe961 100644 --- a/src/rgen/Microsoft.Macios.Generator/DataModel/Property.cs +++ b/src/rgen/Microsoft.Macios.Generator/DataModel/Property.cs @@ -60,7 +60,7 @@ public bool Equals (Property other) if (!attrsComparer.Equals (Attributes, other.Attributes)) return false; - var modifiersComparer = new ModifiersComparer (); + var modifiersComparer = new ModifiersEqualityComparer (); if (!modifiersComparer.Equals (Modifiers, other.Modifiers)) return false; diff --git a/src/rgen/Microsoft.Macios.Generator/DictionaryComparer.cs b/src/rgen/Microsoft.Macios.Generator/DictionaryComparer.cs index 23b7983b5ec1..02f8e3058f2c 100644 --- a/src/rgen/Microsoft.Macios.Generator/DictionaryComparer.cs +++ b/src/rgen/Microsoft.Macios.Generator/DictionaryComparer.cs @@ -5,11 +5,12 @@ namespace Microsoft.Macios.Generator; public class DictionaryComparer (IEqualityComparer? valueComparer = null) - : IEqualityComparer> + : EqualityComparer> where TKey : notnull { readonly IEqualityComparer valueComparer = valueComparer ?? EqualityComparer.Default; - public bool Equals (IDictionary? x, IDictionary? y) + /// + public override bool Equals (IDictionary? x, IDictionary? y) { if (x is null && y is null) return true; @@ -24,7 +25,8 @@ public bool Equals (IDictionary? x, IDictionary? y) return x.All (pair => valueComparer.Equals (pair.Value, y [pair.Key])); } - public int GetHashCode (IDictionary obj) + /// + public override int GetHashCode (IDictionary obj) { var hash = new HashCode (); foreach (var (key, value) in obj) { diff --git a/src/rgen/Microsoft.Macios.Generator/ListComparer.cs b/src/rgen/Microsoft.Macios.Generator/ListComparer.cs index f2038513f150..1d90776f5a97 100644 --- a/src/rgen/Microsoft.Macios.Generator/ListComparer.cs +++ b/src/rgen/Microsoft.Macios.Generator/ListComparer.cs @@ -3,7 +3,7 @@ namespace Microsoft.Macios.Generator; -public class ListComparer : IEqualityComparer> { +public class ListComparer : EqualityComparer> { readonly IComparer comparer; readonly IEqualityComparer valueComparer; @@ -13,7 +13,8 @@ public ListComparer (IComparer sortComparer, IEqualityComparer? equalityCo valueComparer = equalityComparer ?? EqualityComparer.Default; } - public bool Equals (List? x, List? y) + /// + public override bool Equals (List? x, List? y) { // bases cases for null or diff size if (x is null && y is null) @@ -37,7 +38,8 @@ public bool Equals (List? x, List? y) return true; } - public int GetHashCode (List obj) + /// + public override int GetHashCode (List obj) { var hash = new HashCode (); foreach (var element in obj) { diff --git a/tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/ModifiersComparerTests.cs b/tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/ModifiersEqualityComparerTests.cs similarity index 81% rename from tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/ModifiersComparerTests.cs rename to tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/ModifiersEqualityComparerTests.cs index 852b0a04c2f5..3e9255ee5679 100644 --- a/tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/ModifiersComparerTests.cs +++ b/tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/ModifiersEqualityComparerTests.cs @@ -6,15 +6,15 @@ namespace Microsoft.Macios.Generator.Tests.DataModel; -public class ModifiersComparerTests { - readonly ModifiersComparer comparer = new ModifiersComparer (); +public class ModifiersEqualityComparerTests { + readonly ModifiersEqualityComparer equalityComparer = new ModifiersEqualityComparer (); [Fact] public void CompareEmpty () { var x = ImmutableArray.Empty; var y = ImmutableArray.Empty; - Assert.True (comparer.Equals (x, y)); + Assert.True (equalityComparer.Equals (x, y)); } [Fact] @@ -27,7 +27,7 @@ public void CompareDifferentSize () ImmutableArray y = [ SyntaxFactory.Token (SyntaxKind.PublicKeyword), ]; - Assert.False (comparer.Equals (x, y)); + Assert.False (equalityComparer.Equals (x, y)); } [Fact] @@ -41,7 +41,7 @@ public void CompareDifferentModifiers () SyntaxFactory.Token (SyntaxKind.ProtectedKeyword), SyntaxFactory.Token (SyntaxKind.PublicKeyword), ]; - Assert.False (comparer.Equals (x, y)); + Assert.False (equalityComparer.Equals (x, y)); } [Fact] @@ -56,7 +56,7 @@ public void CompareSameModifiersDiffOrder () SyntaxFactory.Token (SyntaxKind.PublicKeyword), ]; - Assert.True (comparer.Equals (x, y)); + Assert.True (equalityComparer.Equals (x, y)); } [Fact] @@ -71,6 +71,6 @@ public void CompareSameModifiers () SyntaxFactory.Token (SyntaxKind.PrivateKeyword), ]; - Assert.True (comparer.Equals (x, y)); + Assert.True (equalityComparer.Equals (x, y)); } } diff --git a/tools/devops/automation/templates/build/api-diff-build-and-detect.yml b/tools/devops/automation/templates/build/api-diff-build-and-detect.yml index 9cf2465bedc7..922f6928e7a4 100644 --- a/tools/devops/automation/templates/build/api-diff-build-and-detect.yml +++ b/tools/devops/automation/templates/build/api-diff-build-and-detect.yml @@ -35,15 +35,6 @@ parameters: # build the source code (build.yml) and detect changes (the nested api-diff.yml) steps: -# The following checkout(s) are needed due in order to get the proper set of credentials stored in the git config. -# Without this, then when the `make reset` command is run, any modules that aren't configured already as submodules -# will be cloned again. This is fine for all GitHub repos, but falls over for AzDo repos. -- checkout: macios-adr-tmp - clean: true - persistCredentials: true - fetchTags: false - path: a/change-detection/tmp/src/macios-adr # Path is rooted from $(Pipeline.Workspace) e.g./Users/builder/azdo/_work/18 - - template: build.yml parameters: isPR: ${{ parameters.isPR }}