Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering MonoComponents when building remotely doesn't work #21244

Open
rolfbjarne opened this issue Sep 16, 2024 · 0 comments
Open

Filtering MonoComponents when building remotely doesn't work #21244

rolfbjarne opened this issue Sep 16, 2024 · 0 comments
Labels
bug If an issue is a bug or a pull request a bug fix windows-only The issue only occur on Windows
Milestone

Comments

@rolfbjarne
Copy link
Member

rolfbjarne commented Sep 16, 2024

This code:

<!-- Remove files mono told us not to link with -->
<_MonoLibrary Remove="@(_MonoRuntimeComponentDontLink -> '$(_MonoRuntimePackPath)native/%(Identity)')" />

doesn't work when building remotely.

Example binlog output (binlog from #21142 (comment)):

Screenshot 2024-09-16 at 16 21 17

vs a build on macOS (locally by me):

Screenshot 2024-09-16 at 16 21 26

My initial unverified guess is because of the differences in the directory separator, but this needs verifying (preferably by a test).

Note that this doesn't seem to cause any problems, unless the customer explicitly asks us to pass -all_load to the native linker, in which the linker fails complaining about duplicate symbols.

@rolfbjarne rolfbjarne added bug If an issue is a bug or a pull request a bug fix windows-only The issue only occur on Windows labels Sep 16, 2024
@rolfbjarne rolfbjarne added this to the .NET 10 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug If an issue is a bug or a pull request a bug fix windows-only The issue only occur on Windows
Projects
None yet
Development

No branches or pull requests

1 participant