-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rgen] Implement the filtering in the transformer tool. #22012
Conversation
Allow the transformer to choose the topic for a base declaration by looking at the attribute data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 19 changed files in this pull request and generated no comments.
Files not reviewed (14)
- src/rgen/Microsoft.Macios.Bindings.Analyzer/Microsoft.Macios.Bindings.Analyzer.csproj: Language not supported
- src/rgen/Microsoft.Macios.Transformer/Microsoft.Macios.Transformer.csproj: Language not supported
- src/rgen/rgen.sln: Language not supported
- tests/rgen/Microsoft.Macios.Transformer.Tests/Microsoft.Macios.Transformer.Tests.csproj: Language not supported
- tests/rgen/Microsoft.Macios.Transformer.Tests/UnitTest1.cs: Evaluated as low risk
- src/rgen/Microsoft.Macios.Transformer/Workers/CopyTransformer.cs: Evaluated as low risk
- src/rgen/Microsoft.Macios.Transformer/Transformer.cs: Evaluated as low risk
- src/rgen/Microsoft.Macios.Transformer/Workers/ProtocolTransformer.cs: Evaluated as low risk
- src/rgen/Microsoft.Macios.Transformer/Workers/ITransformer.cs: Evaluated as low risk
- src/rgen/Microsoft.Macios.Generator/Extensions/TypeSymbolExtensions.Core.cs: Evaluated as low risk
- src/rgen/Microsoft.Macios.Transformer/Workers/ClassTransformer.cs: Evaluated as low risk
- src/rgen/Microsoft.Macios.Transformer/Workers/StrongDictionaryTransformer.cs: Evaluated as low risk
- src/rgen/Microsoft.Macios.Transformer/Workers/SmartEnumTransformer.cs: Evaluated as low risk
- src/rgen/Microsoft.Macios.Transformer/Workers/CategoryTransformer.cs: Evaluated as low risk
Comments suppressed due to low confidence (3)
src/rgen/Microsoft.Macios.Transformer/AttributesNames.cs:7
- [nitpick] The attribute name 'AbstractAttribute' is not fully qualified. Consider using the fully qualified name to avoid ambiguity.
public const string AbstractAttribute = "AbstractAttribute";
src/rgen/Microsoft.Macios.Transformer/AttributesNames.cs:8
- [nitpick] The attribute name 'AdvancedAttribute' is not fully qualified. Consider using the fully qualified name to avoid ambiguity.
public const string AdvancedAttribute = "AdvancedAttribute";
src/rgen/Microsoft.Macios.Transformer/AttributesNames.cs:9
- [nitpick] The attribute name 'BackingFieldTypeAttribute' is not fully qualified. Consider using the fully qualified name to avoid ambiguity.
public const string BackingFieldTypeAttribute = "BackingFieldTypeAttribute";
src/rgen/Microsoft.Macios.Bindings.Analyzer/Microsoft.Macios.Bindings.Analyzer.csproj
Outdated
Show resolved
Hide resolved
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build] Build passed (Build packages) ✅Pipeline on Agent |
✅ [CI Build] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )❗ API diff vs stable (Breaking changes).NET ( ❗ Breaking changes ❗ )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 112 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Allow the transformer to choose the topic for a base declaration by looking at the attribute data.