[Rgen] Add logging to the transformer.

[mandel-macaque]

No description provided.

[Copilot]

Copilot reviewed 5 out of 11 changed files in this pull request and generated 1 comment.

Files not reviewed (6)

• src/rgen/Microsoft.Macios.Transformer/Microsoft.Macios.Transformer.csproj: Language not supported
• src/rgen/Microsoft.Macios.Transformer/Transformer.cs: Evaluated as low risk
• src/rgen/Microsoft.Macios.Transformer/Main.cs: Evaluated as low risk
• src/rgen/Microsoft.Macios.Transformer/Workers/ClassTransformer.cs: Evaluated as low risk
• src/rgen/Microsoft.Macios.Transformer/Workers/ProtocolTransformer.cs: Evaluated as low risk
• src/rgen/Microsoft.Macios.Transformer/Workers/CopyTransformer.cs: Evaluated as low risk

Comments suppressed due to low confidence (2)

src/rgen/Microsoft.Macios.Transformer/Workers/StrongDictionaryTransformer.cs:25

• The error message string contains an unnecessary colon at the end. It should be removed for clarity.

logger.Error (exception, "Error transforming {SymbolName} for path {Path} to {DestinationDirectory}:", message.SymbolName, message.Path, destinationDirectory);

src/rgen/Microsoft.Macios.Transformer/Workers/ErrorDomainTransformer.cs:26

• The error message string ends with a colon, which is unnecessary and could be confusing. It should be removed.

logger.Error (exception, "Error transforming {SymbolName} for path {Path} to {DestinationDirectory}:", 

[Copilot]

The colon at the end of the error message string is unnecessary and could be confusing. It should be removed.

Suggested change

	logger.Error (exception, "Error transforming {SymbolName} for path {Path} to {DestinationDirectory}:",
	logger.Error (exception, "Error transforming {SymbolName} for path {Path} to {DestinationDirectory}",

[github-actions]

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

[vs-mobiletools-engineering-service2]

✅ [PR Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: cef5001bb25dcb29af57470d8108965616942f88 [PR build]

[vs-mobiletools-engineering-service2]

✅ [PR Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 5d6d4e4af7e6224444fdfd05e09fa8cf55aee1f4 [PR build]

[vs-mobiletools-engineering-service2]

✅ [PR Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: cef5001bb25dcb29af57470d8108965616942f88 [PR build]

[vs-mobiletools-engineering-service2]

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 5d6d4e4af7e6224444fdfd05e09fa8cf55aee1f4 [PR build]

[vs-mobiletools-engineering-service2]

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 5d6d4e4af7e6224444fdfd05e09fa8cf55aee1f4 [PR build]

[vs-mobiletools-engineering-service2]

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 5d6d4e4af7e6224444fdfd05e09fa8cf55aee1f4 [PR build]

[vs-mobiletools-engineering-service2]

✅ API diff for current PR / commit

.NET ( No breaking changes )

• iOS: vsdrops gist ( No breaking changes )
• tvOS: vsdrops gist ( No breaking changes )
• MacCatalyst: vsdrops gist ( No breaking changes )
• macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

• iOS: vsdrops gist ( ❗ Breaking changes ❗ )
• tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
• MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
• macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 5d6d4e4af7e6224444fdfd05e09fa8cf55aee1f4 [PR build]

[vs-mobiletools-engineering-service2]

💻 [PR Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 5d6d4e4af7e6224444fdfd05e09fa8cf55aee1f4 [PR build]

[vs-mobiletools-engineering-service2]

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 5d6d4e4af7e6224444fdfd05e09fa8cf55aee1f4 [PR build]

[vs-mobiletools-engineering-service2]

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 111 tests passed.

Failures

❌ monotouch tests (iOS)

1 tests failed, 7 tests passed.

• monotouch-test/iOS - simulator/Release (all optimizations): Failed

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 5d6d4e4af7e6224444fdfd05e09fa8cf55aee1f4 [PR build]