Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect inflight metrics #5412

Open
benjamreis opened this issue Feb 1, 2024 · 1 comment
Open

Incorrect inflight metrics #5412

benjamreis opened this issue Feb 1, 2024 · 1 comment

Comments

@benjamreis
Copy link
Contributor

benjamreis commented Feb 1, 2024

Hello!

A user on our forum reported that the inflight metrics returned by XAPI were incorrect, and it appears
the metrics is being accumulated instead of simply updated with the new value according to @psafont.

What should we do to fix this behavior?

Thanks!

@psafont
Copy link
Member

psafont commented Feb 1, 2024

The solution would be to stop adding current values with the previous ones for gauges in the accumulate function linked in the forum.

You can see which values are used for gauges in the ds_make function: https://github.com/xapi-project/xen-api/blob/master/ocaml/xcp-rrdd/bin/rrdp-iostat/rrdp_iostat.ml#L783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants