Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Algebras improvements #22

Closed
xaviervia opened this issue Jul 24, 2018 · 2 comments
Closed

Algebras improvements #22

xaviervia opened this issue Jul 24, 2018 · 2 comments

Comments

@xaviervia
Copy link
Owner

  • Monoid: Using Fragment it should be implementable. Caveats in Implement Monoid #4 still apply but are ignorable.
  • Profunctor: Current implementation does not follow the laws, since map is implemented as-if ReactDream is the identity functor. To properly implement it, we need to introduce a map2 that composes on the React Element output instead of the React Component, then promap will follow the laws.
@xaviervia
Copy link
Owner Author

Monoid is not implementable even with Fragment, but Semigroup is!

@xaviervia
Copy link
Owner Author

Solved by #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xaviervia