Improve test coverage slightly

Author: pont-us

test/test_cli.py

@@ -1,6 +1,6 @@
-import pathlib
 from unittest.mock import patch
 
+import pytest
 from click.testing import CliRunner
 
 from xcengine.cli import cli
@@ -9,14 +9,16 @@
 @patch("xcengine.core.ScriptCreator.__init__")
 @patch("xcengine.core.ScriptCreator.convert_notebook_to_script")
 @patch("subprocess.run")
-def test_make_script(run_mock, convert_mock, init_mock, tmp_path):
+@pytest.mark.parametrize("verbose_arg", [[], ["--verbose"]])
+def test_make_script(run_mock, convert_mock, init_mock, tmp_path, verbose_arg):
     nb_path = tmp_path / "foo.ipynb"
     nb_path.touch()
     output_dir = tmp_path / "bar"
     init_mock.return_value = None
     runner = CliRunner()
     result = runner.invoke(
         cli,
+        verbose_arg +
         [
             "make-script",
             "--batch",
@@ -37,4 +39,6 @@ def test_make_script(run_mock, convert_mock, init_mock, tmp_path):
             "--from-saved",
         ]
     )
+    from xcengine.cli import logging
+    assert logging.getLogger().getEffectiveLevel() == (logging.DEBUG if "--verbose" in verbose_arg else logging.WARNING)
     assert result.exit_code == 0

test/test_parameters.py

@@ -275,12 +275,14 @@ def test_parameters_read_env_arguments(notebook_parameters):
             }.items()
         }
     )
-    assert notebook_parameters.read_params_from_env() == {
+    expected = {
         "some_int": 42,
         "some_float": 3.14159,
         "some_string": "foo",
         "some_bool": False,
     }
+    assert notebook_parameters.read_params_from_env() == expected
+    assert notebook_parameters.read_params_combined([]) == expected
 
 
 def test_parameters_read_params_combined(notebook_parameters):
@@ -290,7 +292,6 @@ def test_parameters_read_params_combined(notebook_parameters):
             prefix + k: v
             for k, v in {
                 "some_int": "42",
-                "some_float": "3.14159",
                 "some_string": "foo",
                 "some_bool": "False",
             }.items()